test: move async-test-lib to 1.7.3 and drop the removed UNCOMMITTED_CHANGES exclusion - #60
Merged
Merged
Conversation
…HANGES exclusion
Bumping async-test-lib from 1.7.0-RC8 to the 1.7.3 release broke compilation:
ConcurrencySafetyTest.java:54: error: cannot find symbol
@AsyncTest(threads = 8, invocations = 100, excludes = DetectorType.UNCOMMITTED_CHANGES)
symbol: variable UNCOMMITTED_CHANGES location: class DetectorType
Eight call sites, all the same cause. Verified against the jars published on Maven
Central (sha1-checked, because this machine's ~/.m2 held local builds masquerading as
releases): the DetectorType constant set went 127 at 1.7.0 and 1.7.1, 128 at 1.7.2
(FLOW_PUBLISHER_CONCURRENCY added), then 127 at 1.7.3 with UNCOMMITTED_CHANGES removed.
async-test-lib documents that removal as intentional and breaking: the detector shelled
out to `git status --porcelain`, an environment check rather than a concurrency property,
and its subprocess once accounted for 99% of the analysis sweep.
The exclusion existed only to silence that detector against this project's intentionally
dirty tree, so it goes away with the detector rather than needing a replacement. No other
detector inspects the working tree, and no assertion depended on it.
./gradlew test: 225 tests, 0 failures, with ConcurrencySafetyTest contributing all 8 of
its @AsyncTest methods.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UwuXPyu9Mj2JaLMm1vJnRv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
async-test-libfrom 1.7.0-RC8 to 1.7.3 and removes the eightexcludes = DetectorType.UNCOMMITTED_CHANGESattributes that no longer compile.The break
The bump alone does not build:
Eight call sites, one cause.
What actually changed upstream
Checked against the jars published on Maven Central, sha1-verified, because this machine's
~/.m2turned out to hold local builds masquerading as released versions — the constant countsread off those cached jars gave a different and wrong answer:
FLOW_PUBLISHER_CONCURRENCYaddedUNCOMMITTED_CHANGESremovedasync-test-lib documents the removal as intentional and breaking. The detector shelled out to
git status --porcelain— an environment check rather than a property of the code under test —and its subprocess once accounted for 99% of the analysis sweep.
Why the exclusion just goes away
It existed solely to silence that detector against this project's intentionally dirty working
tree. With the detector gone there is nothing to exclude, no other detector inspects the working
tree, and no assertion depended on it. The class javadoc is updated to record why the paragraph
about it disappeared.
Verified
./gradlew test:All eight
@AsyncTestmethods ran — checked in the JUnit XML rather than inferred from a greenbuild.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UwuXPyu9Mj2JaLMm1vJnRv