chore(ci): pin the demo pip install by hash - #209
Merged
Conversation
… alert Scorecard alert 51: a version pin alone still trusts whatever PyPI serves at download time. The install now goes through a requirements file with --require-hashes, carrying PyPI's published sha256 for both 2.4.0 artifacts (wheel and sdist). asciinema declares no dependencies, so that single entry is the complete hash closure pip verifies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UsCqogShCj1AVTEcP4FzLg
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes code-scanning alert 51, the one Scorecard finding PR #206 left behind: a version pin alone (asciinema==2.4.0) still trusts whatever PyPI serves at download time, and Scorecard's PinnedDependencies check wants pip installs hash-verified.
The install now goes through tools/demo/requirements.txt with --require-hashes, carrying PyPI's published sha256 for both 2.4.0 artifacts (wheel and sdist fallback). asciinema declares no dependencies (requires_dist is empty), so that single entry is the complete hash closure pip verifies.
Verified: demo.yml still parses as YAML; the hashes are PyPI's own published digests for the 2.4.0 release files.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UsCqogShCj1AVTEcP4FzLg