Kokkos intermittent gpu bug#230
Open
stevendargaville wants to merge 60 commits into
Open
Conversation
…ices with local column indices to prevent OOB errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is attempting to find an intermittent segfault when run with Kokkos on GPUs in parallel.
There are several bug fixes in this PR, but there is still at least one existing bug still present. Many of the changes in this PR are timing modifications (like using synchronous comms) that make it less likely to trigger the existing bug (perhaps a race condition or out of bounds access).