Skip to content

Modify history state instead of overwriting it #6

Description

@ema-fox

Please consider only modifying the history state and not completely overwriting it.

I haven't tested it but[1] changing this line:

state {:scroll-top scroll-top}]

to:
state (assoc (js->clj (get-history-state)) :scroll-top scroll-top)]
should make Clerk play nice with other code that also makes use of the history state.

[1] I have tested it now and it seems to work.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions