Skip to content

Post-release papercuts: fail-closed lockfile check, llvm classifier, version-agnostic docs #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciaranra merged 3 commits into from
Jul 12, 2026
Merged

Post-release papercuts: fail-closed lockfile check, llvm classifier, version-agnostic docs #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e49975a
Fail closed on unexpected untracked lockfiles, fix pecos-rslib-llvm O…
ciaranra Jul 11, 2026
8f804f2
Merge branch 'dev' into postrelease-papercuts
ciaranra Jul 11, 2026
7c434f9
Merge branch 'dev' into postrelease-papercuts
ciaranra Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/user-guide/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ LLVM 21.1:

Python:
[OK] uv: uv 0.11.3
[OK] import pecos: v0.9.0.dev0
[OK] pecos_rslib: v0.2.0-dev.0
[OK] import pecos: v<version>
[OK] pecos_rslib: v<version>

CUDA (optional):
[--] CUDA: not found (optional)
Expand Down
2 changes: 1 addition & 1 deletion python/pecos-rslib-llvm/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ classifiers = [
"Intended Audience :: Developers",
"Intended Audience :: Science/Research",
"License :: OSI Approved :: Apache Software License",
"Operating System :: POSIX :: Linux",
"Operating System :: OS Independent",
"Topic :: Scientific/Engineering :: Physics",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.10",
Expand Down
16 changes: 16 additions & 0 deletions scripts/dependency-integrity-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,22 @@ if ((${#cargo_locks[@]} == 0)); then
fail "no Cargo.lock files found"
else
for lockfile in "${cargo_locks[@]}"; do
# Fail-closed handling for lockfiles that are not tracked by git:
# - gitignored ones are documented generated artifacts (see .gitignore
# for the per-entry rationale); CI checkouts never contain them and a
# stale local copy fails --locked with a misleading error, so skip.
# - anything else is an unexpected lock that should either be committed
# or gitignored with a rationale -- fail so it cannot slip through.
# (rg --files can list gitignored files under negation patterns, which
# is how these reach this loop at all.)
if ! git ls-files --error-unmatch "$lockfile" >/dev/null 2>&1; then
if git check-ignore -q "$lockfile"; then
echo "Skipping gitignored generated lockfile: $lockfile"
continue
fi
fail "$lockfile is untracked and not gitignored: commit it or gitignore it with a rationale"
continue
fi
manifest="$(dirname "$lockfile")/Cargo.toml"
if [[ ! -f "$manifest" ]]; then
fail "$lockfile has no adjacent Cargo.toml"
Expand Down
Loading