Use different api4.thetvdb.com endpoint for getting all the series#79
Open
roosnic1 wants to merge 1 commit into
Open
Use different api4.thetvdb.com endpoint for getting all the series#79roosnic1 wants to merge 1 commit into
roosnic1 wants to merge 1 commit into
Conversation
…ays get german episode titles even if the series is originally in french e.g. 'Les Dessous des Cartes / Mit offenen Karten'
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I had a problem with the series "Mit offenen Karten" in french "Les Dessous des Cartes". The function
GetShowInfoByTvdbIdinItemLookupServiceuses theget_show.php?tvdid={tvdbid}but in the specific case of "Mit offenen Karten"get_showreturned the episodes with the french episode titles. Because of this theMatchingStrategy.ItemTitleExactfailed since it's comparing German to French episode titles.With the endpoint
https://api4.thetvdb.com/v4/series/$tvdbId/episodes/default/deuit's guaranteed that the episode titles are in German as long as their is a translation.I tested the change with "Mit offenen Karten" and "ZDF Magazin Royale".
I also added a new rule for the rulesets but i read in an issues that @PCJones plans to make that more dynamic anyway. But to be complete here the added rule:
{ "id": 98, "mediaId": 63, "topic": "Aktuelles und Gesellschaft - Hintergrund", "priority": 99, "filters": "[{\"attribute\":\"duration\",\"type\":\"GreaterThan\",\"value\":\"10\"}]", "titleRegexRules": "[{\"type\":\"regex\",\"field\":\"title\",\"pattern\":\"^Mit offenen Karten - (.+)$\"}]", "episodeRegex": "", "seasonRegex": "", "matchingStrategy": "ItemTitleExact", "media": { "media_id": 63, "media_name": "Mit offenen Karten", "media_type": "show", "media_tmdbId": null, "media_imdbId": "n/a", "media_tvdbId": 109331 } }