Skip to content

Use different api4.thetvdb.com endpoint for getting all the series#79

Open
roosnic1 wants to merge 1 commit into
PCJones:v2from
roosnic1:b/fixes-for-mapping-the-world
Open

Use different api4.thetvdb.com endpoint for getting all the series#79
roosnic1 wants to merge 1 commit into
PCJones:v2from
roosnic1:b/fixes-for-mapping-the-world

Conversation

@roosnic1

@roosnic1 roosnic1 commented Mar 8, 2026

Copy link
Copy Markdown

Hi

I had a problem with the series "Mit offenen Karten" in french "Les Dessous des Cartes". The function GetShowInfoByTvdbId in ItemLookupService uses the get_show.php?tvdid={tvdbid} but in the specific case of "Mit offenen Karten" get_show returned the episodes with the french episode titles. Because of this the MatchingStrategy.ItemTitleExact failed since it's comparing German to French episode titles.

With the endpoint https://api4.thetvdb.com/v4/series/$tvdbId/episodes/default/deu it's guaranteed that the episode titles are in German as long as their is a translation.

I tested the change with "Mit offenen Karten" and "ZDF Magazin Royale".

I also added a new rule for the rulesets but i read in an issues that @PCJones plans to make that more dynamic anyway. But to be complete here the added rule:

{
      "id": 98,
      "mediaId": 63,
      "topic": "Aktuelles und Gesellschaft - Hintergrund",
      "priority": 99,
      "filters": "[{\"attribute\":\"duration\",\"type\":\"GreaterThan\",\"value\":\"10\"}]",
      "titleRegexRules": "[{\"type\":\"regex\",\"field\":\"title\",\"pattern\":\"^Mit offenen Karten - (.+)$\"}]",
      "episodeRegex": "",
      "seasonRegex": "",
      "matchingStrategy": "ItemTitleExact",
      "media": {
        "media_id": 63,
        "media_name": "Mit offenen Karten",
        "media_type": "show",
        "media_tmdbId": null,
        "media_imdbId": "n/a",
        "media_tvdbId": 109331
      }
}

…ays get german episode titles even if the series is originally in french e.g. 'Les Dessous des Cartes / Mit offenen Karten'
@PCJones

PCJones commented May 7, 2026

Copy link
Copy Markdown
Owner

Hey, thanks for contributing! I've been super busy and missed this somehow, sorry about that!

I will definitely merge this if it holds up after some testing :)
Should fix #35 #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants