Pn/tauri/dark mode button#514
Open
psnairne wants to merge 7 commits into
Open
Conversation
Comment on lines
+16
to
+21
| <span class="font-semibold text-gray-700">Dark mode:</span> | ||
| <p-toggleSwitch /> | ||
| </div> | ||
|
|
||
| <div class="settings-row"> | ||
| <span class="font-semibold text-gray-700">ORCID:</span> |
Collaborator
There was a problem hiding this comment.
Please do not force hardcoded colors. If we change themes, then these colors will stay.
Suggested change
| <span class="font-semibold text-gray-700">Dark mode:</span> | |
| <p-toggleSwitch /> | |
| </div> | |
| <div class="settings-row"> | |
| <span class="font-semibold text-gray-700">ORCID:</span> | |
| <span class="font-semibold">Dark mode:</span> | |
| <p-toggleSwitch /> | |
| </div> | |
| <div class="settings-row"> | |
| <span class="font-semibold">ORCID:</span> |
Collaborator
There was a problem hiding this comment.
If you want to use font-semibold in this menu, please adjust the csv menu as well. So, things are consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets you click on Settings, and it presents a toggle and a text box which do nothing (yet).
I think this helped me understand somewhat
a) HTML/CSS
b) Routing
Next PR I need to understand how to get things to talk to the backend