MultiContext#487
Open
SmartMonkey-git wants to merge 8 commits into
Open
Conversation
psnairne
reviewed
May 21, 2026
| let hpo_or_disease_col_names = table | ||
| .filter_columns() | ||
| .where_data_context_kind(Filter::Is(&ContextKind::HpoOrDisease)) | ||
| .where_data_context_kind(Filter::Is(&ContextKind::MultiContext)) |
Contributor
There was a problem hiding this comment.
don't we need to filter based on where_data_context instead of data_context_kind?
This code will cause problems if there are other MultiContext columns in the CDF
| .is_empty() | ||
| let series_contexts = table | ||
| .filter_series_context() | ||
| .where_data_context_kind(Filter::Is(&ContextKind::MultiContext)) |
Contributor
There was a problem hiding this comment.
same here, why not use where_data_context?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing MultiContext to give a column multiple contexts at once. I removed the HpoAndDisease Context. Will need this shortly.
The HashableSet got introduced, because using a simple HashSet as the value for the multi context would lead to infinite recursion, where a HashSet gets Hashed until your CPU dies.