Skip to content

Clean up#463

Merged
SmartMonkey-git merged 4 commits into
mainfrom
rr/refactor-interpre
Mar 20, 2026
Merged

Clean up#463
SmartMonkey-git merged 4 commits into
mainfrom
rr/refactor-interpre

Conversation

@SmartMonkey-git

@SmartMonkey-git SmartMonkey-git commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

This PR does a little clean up.

Interpretation collector

  • Got rid if the unnecessary construction of the bb to cdf hashmap
  • Removed the closure in favor of a column in collect_genes_and_variants_in_bb
  • Added a simple function to check wether a building block is spread across multiple cfds
  • Got rid of the ambiguous cdf name check

@psnairne Let me know if the logic works

Filters

  • Removed the SeriesFilter input to the ColumnFilter
  • This lets us clean up get_single_linked_column_as_str's interface

@SmartMonkey-git SmartMonkey-git self-assigned this Mar 20, 2026

@psnairne psnairne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this!

Comment thread phenoxtract/src/extract/column_filter.rs Outdated
Comment thread phenoxtract/src/transform/collecting/individual_collector.rs
Comment thread phenoxtract/src/transform/collecting/interpretation_collector.rs
Comment thread phenoxtract/src/transform/collecting/interpretation_collector.rs
@SmartMonkey-git
SmartMonkey-git merged commit 3690f9f into main Mar 20, 2026
4 checks passed
@SmartMonkey-git
SmartMonkey-git deleted the rr/refactor-interpre branch March 20, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants