Change to a CJS fallback instead of ESM fallback - #3
Closed
darcyrush wants to merge 1 commit into
Closed
Conversation
Author
|
Actually now that Node20 is Eol, the correct packaging method is much more simple and the project only needs to be exported in one format - either CJS or ESM |
Author
|
Superseded by #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the dual package setup within this project currently has a fallback for ESM projects which are using legacy node module resolution settings.
However, I believe such projects are incredibly rare given that good node ESM support has been something very recent and the legacy node module resolution issue was resolved many years before that point. As such, most ESM projects are likely using modern configuration settings, or can fairly easily migrate to modern configuration settings.
More commonly it is old CJS projects which are using legacy node module resolution settings and are in no position to update.
Still, this is technically a breaking change, so this is your call, but I believe the percentage of CJS users impacted by not having a CJS fallback is far higher than ESM.