fix(sftp): resolve symlinks for accurate download progress (#52) - #53
Merged
Conversation
Three fixes for download progress stuck at 0% in symlinked directories: 1. Use sftp.realpath() before stat() in SFTPClient.download() so file size is read from the resolved target, not the symlink entry. 2. Guard item.total_bytes in transfer callbacks: do not overwrite a positive value with 0 when the progress handler reports total=0. 3. Re-stat zero-size files in recursive downloads before summing total_bytes, catching symlink entries whose size was reported as 0 by the directory listing. Closes #52 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes download progress stuck at 0% for files in symlinked directories.
SFTPClient.download()now callssftp.realpath()before stat/get to resolve symlinks, falling back to the original path if realpath failsitem.total_bytes— a reportedtotal=0no longer overwrites a previously known positive valuesize=0(common for symlink entries in directory listings) before summingtotal_bytesTest plan
SFTPClient.download()(native get, BytesIO fallback, realpath failure)Closes #52
🤖 Generated with Claude Code