fix(sftp): wire asyncssh progress_handler for transfer progress - #48
Merged
Conversation
After the asyncssh migration, SFTP downloads/uploads showed 0% progress because the manual chunk-read loop bypassed asyncssh's pipelined I/O and native progress reporting. Switch SFTPClient.download() and upload() to use sftp.get()/sftp.put() with their progress_handler callback. This gives pipelined reads/writes for better throughput and correct progress updates via the existing wx.PostEvent thread-safe notification path. A chunked-read fallback is retained for in-memory BinaryIO streams (BytesIO) used in tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45 — rebased cleanly onto dev after asyncssh migration merge.
Wires up asyncssh
progress_handlerfor both uploads and downloads so the UI progress bar updates correctly. Ensures progress callbacks dispatch to the wx main thread viawx.CallAfter.6 new tests covering progress updates, no-callback path, BytesIO fallback, and upload size verification. 352 tests passing.