This repository was archived by the owner on Apr 12, 2026. It is now read-only.
test: improve meteor API test coverage from 72% to ~99% - #5
Merged
Conversation
Add 22 new tests covering: - MeteorShower.activity_days property (year-spanning, default) - MeteorShowerInfo viewing_rating branches (Excellent/Good/Fair/Poor) - MeteorShowerInfo __str__ branches (peak tonight/future/passed) - _get_activity_range helper (with dates, year-spanning, default) - get_upcoming_showers/get_active_showers default parameters - get_active_showers year-boundary peak adjustment - get_shower_info default year and partial matching - MeteorClient async interface (all methods)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 22 new tests to
tests/test_meteor_api.pyimproving coverage forsrc/accessisky/api/meteors.pyfrom 72% to approximately 99%.New tests cover:
Test results
ruff check .passes)