feat(lib): Bump button v3.3.0, expand button v3.2.0 and navigation button v3.3.0#3713
Open
louismaximepiton wants to merge 3 commits into
Open
Conversation
github-project-automation
Bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OUDS Web’s button sizing API and migration tooling to reflect the latest upstream button changes (notably the deprecation of .btn-sm in favor of .btn-small), and documents the new sizing guidance.
Changes:
- Document
.btn-smallsizing and update migration notes to reflect.btn-sm→.btn-smalland.btn-lgremoval. - Update SCSS to support
.btn-smalland align internal component usage (e.g., quantity selector) with the new class name. - Update migrate replacement rules and snapshots to automatically migrate
btn-smtobtn-smalland reflect new CSS output.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/content/docs/getting-started/migration-from-boosted.mdx | Updates migration guidance for button size classes. |
| site/src/content/docs/components/buttons.mdx | Adds a “Sizes” section documenting .btn-small with examples. |
| scss/_buttons.scss | Introduces the .btn-small variant via CSS custom property overrides. |
| scss/forms/_quantity-selector.scss | Aligns quantity selector styling with .btn-small instead of .btn-sm. |
| scss/_button-group.scss | Minor comment update reflecting removal of .btn-sm/.btn-lg. |
| scss/tests/snapshot-tests/snapshots/ouds-web.css | Updates CSS snapshot output for .btn-small and quantity selector selectors. |
| scss/tests/snapshot-tests/snapshots/ouds-web-bootstrap.css | Updates Bootstrap CSS snapshot output for .btn-small and quantity selector selectors. |
| packages/migrate/src/replacements/boosted.mjs | Changes migration behavior to replace btn-sm with btn-small (instead of warning). |
| packages/migrate/tests/source-boosted.html | Updates migration fixture input for the btn-sm case. |
| packages/migrate/tests/snapshots/migrated-boosted.html | Updates expected migrated output to use btn-small. |
| packages/migrate/src/migrate.spec.mjs | Updates expected warnings list to remove the btn-sm deprecation warning. |
Files not reviewed (2)
- scss/tests/snapshot-tests/snapshots/ouds-web-bootstrap.css: Generated file
- scss/tests/snapshot-tests/snapshots/ouds-web.css: Generated file
Comments suppressed due to low confidence (1)
site/src/content/docs/components/buttons.mdx:575
- This sprite reference is hardcoded to
/orange/docs/1.4/..., which will break on other brands and when the docs version changes. UsegetVersionedDocsPath()like the other button examples in this file.
<svg aria-hidden="true">
<use xlink:href="/orange/docs/1.4/assets/img/ouds-web-sprite.svg#heart-empty"/>
</svg>
Collaborator
|
Maybe do this here #3609 (comment) |
MaxLardenois
left a comment
MaxLardenois
left a comment
Collaborator
There was a problem hiding this comment.
1 suggestion, 1 question
| } | ||
|
|
||
| // OUDS mod: no .btn-sm, nor .btn-lg | ||
| // OUDS mod: no .btn-sm, no .btn-lg |
Collaborator
There was a problem hiding this comment.
nor was ok here (but it's a detail)
|
|
||
| ### Sizes | ||
|
|
||
| Buttons are available in two sizes. Add `.btn-small` to have a smaller button. Default size is medium. |
Collaborator
There was a problem hiding this comment.
I do not get the "Default size is medium" as the Default is just default on the design...
|
|
||
| - <span class="tag tag-small tag-info"><span class="tag-status-icon"></span>Info</span> Button component has been updated to 3.3.0. Read more in the [button design changelog](https://r.orange.fr/r/S-ouds-doc-button_changelog). | ||
|
|
||
| - <span class="tag tag-small tag-info"><span class="tag-status-icon"></span>Info</span> Navigation button component has been updated to 3.3.0. Read more in the [button design changelog](https://r.orange.fr/r/S-ouds-doc-button_changelog). |
Collaborator
There was a problem hiding this comment.
Suggested change
| - <span class="tag tag-small tag-info"><span class="tag-status-icon"></span>Info</span> Navigation button component has been updated to 3.3.0. Read more in the [button design changelog](https://r.orange.fr/r/S-ouds-doc-button_changelog). | |
| - <span class="tag tag-small tag-info"><span class="tag-status-icon"></span>Info</span> Navigation button component has been updated to 3.3.0 with no outward changes. Read more in the [button design changelog](https://r.orange.fr/r/S-ouds-doc-button_changelog). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-3713--boosted.netlify.app/orange/docs/components/buttons/#sizes