chore(assets): update build script#3697
Open
louismaximepiton wants to merge 1 commit into
Open
Conversation
github-project-automation
Bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix broken assets/links in the “examples zip” output after the documentation structure changed to a brand-prefixed versioned path, and includes a small docs/resources link correction plus an examples JS global rename.
Changes:
- Update
build/zip-examples.mjsto package additional CSS outputs and to restructure the zip contents under<brand>/docs/<version>/.... - Update HTML rewriting in the zip process (path/integrity handling) to adapt to the new docs structure.
- Fix an external link in
resources.astroand update thedownload-appexample JS to use theoudsWebglobal.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| site/src/pages/resources.astro | Fixes the Boosted website URL. |
| site/src/assets/examples/download-app/download-app.js | Switches the example JS to use the oudsWeb global for Carousel instantiation. |
| build/zip-examples.mjs | Updates the examples zip layout and asset copying logic to follow the new docs folder structure. |
Comment on lines
+101
to
+102
| .replaceAll(new RegExp(`"/docs/${versionShort}/`, 'g'), '"../') | ||
| .replaceAll(/"..\/dist\//g, `"../${brand}/docs/${versionShort}/assets/dist/`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change
Related issues
Closes #3671
Context & Motivation
See #3671
Description
Change the build script unchanged when we made the docs structure changes.
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
mainfollowing conventional commitLive previews