Patch V3Oracle truncations#131
Open
gonzaotc wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for uniswap-hooks-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for uniswap-hooks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ernestognw
reviewed
May 21, 2026
ernestognw
left a comment
ernestognw
left a comment
Member
There was a problem hiding this comment.
The errors should have a different name, otherwise we risk getting an "already-declared identifier" error if both contracts are combined (may not make sense, though)
| using StateLibrary for IPoolManager; | ||
|
|
||
| /// @notice Thrown when `observations(uint256)` is called with an index that does not fit in `uint16`. | ||
| error IndexOutOfRange(); |
Member
There was a problem hiding this comment.
Suggested change
| error IndexOutOfRange(); | |
| error V3OracleAdapterIndexOutOfRange(); |
| using StateLibrary for IPoolManager; | ||
|
|
||
| /// @notice Thrown when `observations(uint256)` is called with an index that does not fit in `uint16`. | ||
| error IndexOutOfRange(); |
Member
There was a problem hiding this comment.
Suggested change
| error IndexOutOfRange(); | |
| error V3TruncatedOracleAdapterIndexOutOfRange(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.