Repository navigation
test(models): stub the disk check in the concurrent-download test - #2804
Merged
Merged
Conversation
The test read the CI runner's real free space and needed ~10.5 GB for the first two registry models (sizes x 1.2 reservation). Runners now have ~8.3 GB free, so every Desktop CI run failed with INSUFFICIENT_DISK_SPACE. Stub checkDiskSpace like the file's other download tests; disk reservation keeps its own test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop CI's
qualityjob has been failing on every branch since 2026-10-19 ~22:48 UTC (#2739 and three other branches), on one test:Root cause: this was the only download test in
modelManagerBridgeDownloadStatus.test.jsthat didn't stubcheckDiskSpace. It reserved the real sizes of the first two registry models, (5.89 GB + 2.87 GB) × 1.2 ≈ 10.5 GB, against the runner's real free space, which is now about 8.3 GB.Fix: pass the same
checkDiskSpacestub the file's other download tests already use. Disk reservation keeps its own test ("parallel downloads reserve their combined disk space").Files
test/helpers/modelManagerBridgeDownloadStatus.test.js: one-linecheckDiskSpacestub in the concurrent-download test.Tests:
node --import tsx --test test/helpers/modelManagerBridgeDownloadStatus.test.jspasses 11/11 (Node 24). I couldn't reproduce a runner with low free disk locally, so this PR's CI run is the real check.Follow-up: after this merges, re-run CI on the branches that failed on it.