Skip to content

Make gui great again #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JarbasAl wants to merge 22 commits into from
Closed

Make gui great again #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8b12ace
test: Add comprehensive GUIService unit tests
JarbasAl Mar 12, 2026
fbdfa88
test: Add comprehensive unit tests for __main__, version, and tui mod…
JarbasAl Mar 12, 2026
ae28e06
test: Add tests for service run() and namespace error handling
JarbasAl Mar 12, 2026
be9029f
docs: Update TODO.md to reflect completed Phase 1-2 work
JarbasAl Mar 12, 2026
947886a
docs: Update all root documentation to reflect Phase 1-3 completion
JarbasAl Mar 12, 2026
c7ecd63
docs: Add QML consolidation plan for GUI ecosystem
JarbasAl Mar 12, 2026
e55b80a
docs: Add comprehensive GUI system status across all repos
JarbasAl Mar 12, 2026
ec78e4f
docs: Add comprehensive user-facing documentation for OVOS GUI
JarbasAl Mar 12, 2026
f66a185
refactor: Remove deprecated modules and bundled QML assets
JarbasAl Mar 12, 2026
c9f2273
refactor: Update core modules for simplified architecture
JarbasAl Mar 12, 2026
69f8fb3
build: Migrate to modern Python packaging (pyproject.toml)
JarbasAl Mar 12, 2026
f849f57
ci: Update GitHub Actions workflows to use standard gh-automations
JarbasAl Mar 12, 2026
de717e5
docs: Update GUI_DESIGN.md with OCP media player template
JarbasAl Mar 12, 2026
ce63e63
update
JarbasAl Mar 12, 2026
2960a89
docs: reorganize into hierarchical docs structure with role-based nav…
JarbasAl Mar 12, 2026
dc60a7d
docs: add comprehensive documentation reorganization guide
JarbasAl Mar 12, 2026
f5c5420
docs: add GUI history section to DEPRECATION_GUIDE, create FAQ
JarbasAl Mar 12, 2026
64c1f25
docs: remove ovos-media references, simplify legacy QML FAQ
JarbasAl Mar 12, 2026
2ad7576
docs: add protocol extensions for shell features
JarbasAl Mar 12, 2026
b8f2b3c
docs: standardize bus message namespaces to unified ovos.shell.* patt…
JarbasAl Mar 12, 2026
28eb271
docs: add prominent reference to two-bus architecture in protocol ext…
JarbasAl Mar 12, 2026
aa7aa8a
docs: CRITICAL FIX - correct port 8181 access information for clients
JarbasAl Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/license_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
name: Run License Tests
on:
push:
workflow_dispatch:
pull_request:
branches:
- master
pull_request:
branches:
- dev
workflow_dispatch:

jobs:
license_tests:
uses: neongeckocom/.github/.github/workflows/license_tests.yml@master
uses: OpenVoiceOS/gh-automations/.github/workflows/license-check.yml@dev
with:
Comment on lines +13 to +14

@coderabbitai coderabbitai Bot Mar 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

find . -name "license_tests.yml" -o -name "license-check.yml" | head -20

Repository: OpenVoiceOS/ovos-gui

Length of output: 101

🏁 Script executed:

cat .github/workflows/license_tests.yml

Repository: OpenVoiceOS/ovos-gui

Length of output: 302

🌐 Web query:

GitHub Actions reusable workflow empty with block valid syntax

💡 Result:

jobs.<job_id>.with (when calling a reusable workflow via uses:) must be a YAML map. So an “empty with: block” that is parsed as null (e.g., with: with nothing under it) is not valid for GitHub Actions’ schema. GitHub documents with as “a map of inputs that are passed to the called workflow.” [1]

Use one of these instead:

jobs:
  call:
    uses: org/repo/.github/workflows/reusable.yml@main
    # option A: omit `with` entirely (recommended if you have no inputs)
jobs:
  call:
    uses: org/repo/.github/workflows/reusable.yml@main
    # option B: explicit empty map (valid YAML + matches “map”)
    with: {}

Same idea for jobs.<job_id>.secrets (also a map): omit it, use secrets: inherit, or secrets: {} if you truly need an explicit empty map. [1]

Sources
[1] GitHub Docs – Workflow syntax: jobs.<job_id>.with / jobs.<job_id>.secrets https://docs.github.com/en/enterprise-cloud@latest/actions/reference/workflows-and-actions/workflow-syntax

Remove the empty with: block.

Per GitHub Actions workflow syntax, jobs.<job_id>.with must be a YAML map. An empty with: block (parsed as null) violates the schema. Omit it entirely since this reusable-workflow call passes no inputs.

🛠 Suggested fix 
   license_tests:
     uses: OpenVoiceOS/gh-automations/.github/workflows/license-check.yml@dev
-    with:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
uses: OpenVoiceOS/gh-automations/.github/workflows/license-check.yml@dev
with:
license_tests:
uses: OpenVoiceOS/gh-automations/.github/workflows/license-check.yml@dev
🧰 Tools
🪛 actionlint (1.7.11)

[error] 14-14: "with" section should not be empty. please remove this section if it's unnecessary

(syntax-check)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/license_tests.yml around lines 13 - 14, The workflow
contains an empty with: block after the reusable workflow call "uses:
OpenVoiceOS/gh-automations/.github/workflows/license-check.yml@dev"; remove the
entire with: key (the reusable-workflow call takes no inputs) so the call is
valid YAML and complies with the GitHub Actions schema.

186 changes: 0 additions & 186 deletions ADAPTER_COMPATIBILITY_ASSESSMENT.md
View file
Open in desktop

This file was deleted.

Loading
Loading