chore(core): adopt @openvtc/vti-didcomm-js 0.4.2 (diagnostics + inbound resilience) - #52
Merged
Merged
Conversation
Picks up the WS-upgrade close-code diagnostics (so a CORS/ACL/proxy failure surfaces its 1006/1008 cause + endpoint in the plugin instead of an opaque "WebSocket failed to open") and the per-frame inbound resilience (a bad message is logged via the library's onError hook — default console.warn — and skipped rather than silently dropped). No code change needed: the default onError already logs to console, and the diagnostics ride on the existing connect path. Bumps pnm-core (and the private app packages that ship it) to 0.1.2. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@openvtc/vti-didcomm-js0.4.1 → 0.4.2 (now published) so the plugin gets the two robustness improvements from OpenVTC/vti-didcomm-js#2:endpoint, instead of an opaqueWebSocket failed to open. This is exactly the signal that pinned down the CORS issue; having it in the plugin makes the next field failure self-diagnosing.onError, defaultconsole.warn) and skipped, so the session never gets stuck on one poison message.No plugin code change required: the default
onErroralready logs to the console and the diagnostics ride on the existing connect path. A customonErrorsink can be wired throughconnectMediatorSessionlater if we want it in telemetry.Versions
@openvtc/pnm-core0.1.1 → 0.1.2 (+ the private app packages that ship it). Dependents keep their^0.1.xmajor.minor pin.Tests
Build + full core suite: 22 pass, 0 fail. Lockfile diff is just the dep tarball + version bumps.
🤖 Generated with Claude Code