chore(core): 0.7.0 — a minor, because the exported types changed - #158
Merged
Conversation
Minor rather than patch, and the reason is in the Migration section: four
exported types now come from `@openvtc/trust-tasks` instead of being
declared here, and three of them had drifted from the schema.
`AclSwapResult` is the sharp one. `swapAcl` typed its reply as a flat ACL
entry; the agent has responded `{ entry, previousSubject }` since VTI #857,
with `subject` not `did` and `scopes` not `allowedContexts` inside. Every
field a caller read came back `undefined`. Nothing in this repo calls it,
so the change breaks no code here — but any consumer reading the old shape
was already getting nothing, and the new shape is what the agent sends.
`ContextRecord.did`/`.description` moved from `string | null` to optional,
which matters to anyone testing `=== null` — that test never matched a
conforming agent and never will. `WebvhDidRecord` gained seven members it
had been omitting. `PushRegistration` is the generated `WebPush` variant.
Also records the two deleted casing folds and the removal of the exported
`fold()` helper, since that is a public symbol going away.
Dependents moved to `^0.7.0` (extension, pwa) and the lockfile with them.
Verified as it would publish, not just as it builds: `npm pack --dry-run`
resolves 0.7.0 with the new `vault/credentials` and `admin/backup` modules
present, and the built `dist` entry points import cleanly in plain Node —
`files: ["dist"]` means a stale dist ships a broken package and nothing else
would have caught it.
Cold clean/lint/build/test green; 736 tests.
Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and changelog for
@openvtc/pnm-core, ready to publish. npm still serves 0.6.0, which predates the console work now onmain.Why minor, not patch
Four exported types now come from
@openvtc/trust-tasksinstead of being declared locally, and three had drifted from the published schema.AclSwapResultis the sharp one.swapAcltyped its reply as a flat ACL entry —did,role,allowedContexts,createdAt: number. The agent has responded{ entry, previousSubject }since VTI #857, withsubjectnotdidandscopesnotallowedContextsinside. Every field a caller read came backundefined.Nothing in this repo calls
swapAcl, so no code here breaks — but any consumer reading the old shape was already getting nothing, and the new shape is what the agent actually sends.The rest:
ContextRecord.did/.descriptionstring | null=== nullnever matchedWebvhDidRecordserverId/portableoptional, seven members missingmnemonic/scid/logEntryCount/createdAt/… availablePushRegistrationWebPushvariantThe changelog also records the two deleted casing folds and the removal of the exported
fold()helper, since that is a public symbol going away.Verified as it would publish
Not just that it builds.
files: ["dist"]means a stale or missing dist ships a broken package and nothing else in CI would catch it:npm pack --dry-runresolves 0.7.0, 498 files, with the newvault/credentialsandadmin/backupmodules present in the tarballdistentry points import cleanly in plain Node —backupAbort,reloadServices,credVaultGet,isRunnableCredentialQueryall resolveDependents moved to
^0.7.0(extension, pwa) with the lockfile. Coldnpm run clean && npm run lint && npm run build && npm test— 736 tests green.Publishing is manual and needs the OTP, so that stays with the maintainer.