Skip to content

fix(inbound): a throw while handling an inbound message is no longer silent #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stormer78 merged 1 commit into from
Aug 5, 2026
Merged

fix(inbound): a throw while handling an inbound message is no longer silent #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/extension/src/offscreen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1766,6 +1766,24 @@ async function handleInbound(
): Promise<void> {
try {
await dispatchInbound(conn, identity, signing, vtaDid, message, isApprover, fromDrain);
} catch (err) {
// There was no catch here, and the call site is `void handleInbound(...)`.
// So anything dispatch threw — rather than returned as a refusal — became an
// unhandled rejection: no log from this file, no prompt, no decision sent
// back to the executor, and the message already acked to the mediator so its
// queued copy was gone.
//
// That is indistinguishable from a request that never arrived, and it is
// what it looked like: `[pnm inbound] received` followed by silence, while
// the same request dispatched by hand from the console prompted correctly.
// Every deliberate refusal in `dispatchInbound` logs and returns; only a
// *thrown* error could vanish, and nothing was watching for one.
console.error(
"[pnm inbound] handling threw — no prompt was raised for this message:",
typeof message.type === "string" ? message.type : "(no type)",
typeof message.id === "string" ? message.id : "(no id)",
err,
);
} finally {
const id = typeof message.id === "string" ? message.id : undefined;
if (id) {
Expand Down