feat(join): join-as-subject + paste-a-VIC; subject-linkage groundwork#129
Merged
Conversation
#1a Join as the VIC subject: when a loaded/pasted invitation is bound to one of our personas, the join flow presents that persona automatically (holder-binding then matches at the VTC — presenter == VIC subject — with no linkage proof). #3 Paste a VIC into the TUI: pasting a JSON object on the join entry page is treated as an invitation credential — validated (must be an InvitationCredential) and stashed into the join flow, mirroring the `--invitation <file>` flag. The entry page shows a paste hint, and the loaded-invitation indicator on success. openvtc-core groundwork for the linkage path (#1b): `build_join_vp` now takes an optional `SubjectLinkage`; added `SUBJECT_LINKAGE_DOMAIN_TAG` (matches the VTC), `subject_linkage_signing_bytes`, and `invitation_subject` / `invitation_id` extractors. Unit-tested. Remaining (groundwork in place; VTC + SDK already support both): build the subject-linkage signature in the join flow for a fresh presenting DID (#1b), and load/store the VIC via the VTA credential vault (cred_vault_*) instead of the file/paste path (#2). Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applicant-side follow-ups to the VIC join flow. Companion to verifiable-trust-infrastructure #526.
What's included
#1a — Join as the VIC subject. When a loaded (
--invitation) or pasted invitation is bound to one of our personas, the join flow presents that persona automatically — holder-binding then matches at the VTC (presenter == VIC subject) with no linkage proof needed.#3 — Paste a VIC into the TUI. Pasting a JSON object on the join entry page is treated as an invitation credential: validated (must be an
InvitationCredential) and stashed into the join flow, mirroring the--invitation <file>flag. The entry page shows a paste hint and the loaded-invitation indicator.#1b groundwork.
openvtc_core::join::build_join_vpnow takes an optionalSubjectLinkage; addedSUBJECT_LINKAGE_DOMAIN_TAG(byte-matches the VTC's),subject_linkage_signing_bytes, andinvitation_subject/invitation_idextractors. Unit-tested.Remaining (groundwork in place; VTC + SDK already support both)
cred_vault_*) instead of the file/paste path.Tests
openvtc-corejoin helpers unit-tested (5); binary builds; fmt clean.🤖 Generated with Claude Code