Run duplicate checks during schema-only validation - #1266
Open
be-student wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1265
Validation
npm run test:only -- scripts/declarations/validate/index.test.js scripts/declarations/validate/schemas.test.js(20 passing)NODE_ENV=test npm run declarations:validate:schema -- --services service_with_multiple_source_documents_terms(4 passing, including duplicate validation)npx eslint scripts/declarations/validate/index.test.js scripts/declarations/validate/index.mocha.jsgit diff --checkThe full
npm testrun reached 1,250 passing tests. Three Mongo setup hooks timed out because no local Mongo service was available, and the existing dataset export test found a generated README mismatch. The new CLI regression initially hit Mocha's two-second suite timeout and now has an explicit ten-second limit; it passes in 0.7-1.1 seconds.