Repository navigation
Pairing 5/6: offer supported main bands on first run #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikenrafter
wants to merge
23
commits into
OpenStrap:main
Choose a base branch
from
mikenrafter:split/669-first-run
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,135
−161
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d4594f4
feat(pairing): add a shared device flow and retain the old band until…
mikenrafter e2826e7
feat(pairing): offer only supported main bands on first run
mikenrafter 719408e
merge main
abdulsaheel ad979d2
replace band: keep the old band's saved name until the replacement co…
abdulsaheel 5d5d966
merge main
abdulsaheel a700ad3
first run: the whoop description only shows under whoop rows
abdulsaheel 1f70ba7
merge main
abdulsaheel aa76467
merge main
abdulsaheel b7cfe7d
merge main
abdulsaheel a6ac04f
merge main
abdulsaheel 9751bba
Merge branch 'split/669-reset-help' into split/669-add-device
mikenrafter 07a9837
Keep band replacement isolated and pairing taps reliable
mikenrafter 547d368
Merge branch 'split/669-add-device' into split/669-first-run
mikenrafter b7e4595
Merge branch 'split/669-add-device' into split/669-first-run
mikenrafter bbd2c1f
Keep reset guard checks aligned with band replacement
mikenrafter a3ba119
Distinguish generation comparisons from default assignments
mikenrafter 41963d4
Merge branch 'split/669-reset-help' into split/669-add-device
mikenrafter 9f95b8d
Merge branch 'split/669-add-device' into split/669-first-run
mikenrafter 2a0f91e
Keep replacement state scoped to the paired band
mikenrafter 3ac5229
Merge branch 'split/669-add-device' into split/669-first-run
mikenrafter 437c438
Exercise the scan race from the sensor picker
mikenrafter 4ce7745
merge main
abdulsaheel b1e0e13
merge split/669-add-device
abdulsaheel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass the import's reset generation into step-coverage writes.
flushStepCoverageawaitsLocalDb.coverageWindowsOverlappingand then callsaddLiveCoveragewithoutresetGeneration(lib/import/noop_ingest.dart:476-479).addLiveCoveragecapturesResetGate.generationonly when it runs (lib/data/db.dart:4311). A reset that starts during the await is therefore not seen. The insert can then commit after_wipeAllLockedon the same commit gate, which leaves the stale step rows in the fresh database.The import does not take the derive lock that
acquireForReset()waits for, and nothing checks the reset state after the await. Pass the generation the import captured at start (_resetGen, line 84) through the flush.Suggested fix