Repository navigation
Pairing 3/6: add reset help and a public WHOOP 5 source #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,133
−19
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2e21d90
feat(pairing): add reset help with a public WHOOP 5 source
mikenrafter 250ca91
feat(pairing): add reset help with a public WHOOP 5 source
mikenrafter 65c65ad
merge main
abdulsaheel 6742a2f
reset help: drop internal review tags from comments and test names
abdulsaheel f0f706f
merge main
abdulsaheel a3f9864
Keep pairing guidance safe and label unverified steps
mikenrafter 7c1b58f
merge main
abdulsaheel a0930c1
List Forget before the device's own reset steps on a refused bond
mikenrafter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Check of a vendor help URL against the entry's pinned official host. | ||
|
|
||
| /// Null when [url] is acceptable for an entry whose reviewed host is | ||
| /// [pinnedHost]; otherwise a short reason. Acceptable: https, parseable, host | ||
| /// equal to [pinnedHost] (case-insensitive), no userinfo. | ||
| String? resetUrlProblem(String url, {required String pinnedHost}) { | ||
| final u = Uri.tryParse(url.trim()); | ||
| if (u == null || !u.hasScheme) return 'not a URL'; | ||
| if (u.scheme != 'https') return 'not https'; | ||
| if (u.host.isEmpty) return 'no host'; | ||
| if (u.userInfo.isNotEmpty) return 'has userinfo'; | ||
| if (u.host.toLowerCase() != pinnedHost.toLowerCase()) { | ||
| return 'host ${u.host} is not the pinned $pinnedHost'; | ||
| } | ||
| return null; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.