You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Pin the Health Connect delete-gate test to Health Connect (fails on macOS) - #685
health_workout_export_delete_gate_test ("a failed delete does not write a duplicate on top of it") fails on every Mac and passes in CI.
The exportWorkout delete-then-write group tests the Health Connect reading of a false delete, and its comment assumed "the host VM is neither iOS nor macOS". But HealthExporter.isApple is Platform.isIOS || Platform.isMacOS, and flutter test on a Mac runs on a macOS host VM. There isApple is true, the exporter takes the HealthKit branch (where a false delete is the documented empty-range answer and the write goes ahead, by design), and the test's Health Connect expectation fails. CI runs on ubuntu-latest, so it never sees it; a contributor on a Mac sees a red test unrelated to their change.
The app is fine on both platforms. Only the test was host-dependent.
What changes
lib/health/health_export.dart: a @visibleForTesting static bool? isAppleOverride, read first by isApple. null (the default, and always in the app) keeps the real platform check, so production behaviour is unchanged. Same pattern as ScreenWake.platformOverride in lib/gps/screen_wake.dart.
test/health_workout_export_delete_gate_test.dart: the group pins isAppleOverride = false in setUp and resets it in tearDown, so it tests Health Connect on every host.
Tests
test/health_workout_export_delete_gate_test.dart: 11/11 pass on macOS (was 10/11).
flutter analyze: no issues.
flutter test --concurrency=1: 7010 passed, 28 skipped, 8 failed. The 8 are the ones fix main's test run: missing translations and gallery case #683 fixes (ui2_tokens gallery, russian_localization, russian_review_findings, settings_report_l10n es/fr/hi/zh, thai_l10n); this test is no longer among them.
Not related to #683, which fixes the other red tests on main (translations, gallery); this one is a macOS-only failure #683 doesn't cover.
The `exportWorkout delete-then-write` group tests the Health Connect
reading of a false delete, and assumed a non-Apple host. flutter test
on a Mac runs on a macOS host VM, where HealthExporter.isApple is true:
the exporter takes the HealthKit branch (a false delete is the
documented empty-range answer and the write proceeds, by design) and
"a failed delete does not write a duplicate" fails. CI runs on Linux,
so only contributors on a Mac saw it.
Add a @VisibleForTesting HealthExporter.isAppleOverride (null = the
real platform, so the app is unchanged), the same pattern as
ScreenWake.platformOverride, and pin it to false in that group.
No actionable comments were generated in the recent review.
Walkthrough
HealthExporter accepts an optional Apple-platform test override. When set, export logic uses the selected platform for platform-specific behavior. Otherwise, it uses the actual platform.
Changes: Apple platform detection and export behavior
Layer / File(s)
Summary
Apple platform override lib/health/health_export.dart
Adds an optional nullable test override. The internal platform decision uses it when set and otherwise checks the actual platform. The public storeName remains based on the actual platform.
OpenStrap/edge#653: Reports a macOS Health export test failure caused by an assumption about the host platform’s isApple value.
Suggested reviewers:abdulsaheel
Merge Risk: Minimal · up to 72592
This adds a test-only platform override to the health exporter. Production behavior is unchanged when the override is not set, and no merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the test being pinned and the platform it fixes, which matches the main change (a test-only platform override plus pinning the delete-gate test group to Health Connect). It is specific…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the test being pinned and the platform it fixes, which matches the main change (a test-only platform override plus pinning the delete-gate test group to Health Connect). It is specific, but it is long (74 characters) and the parenthetical reads like a failure report, so it is not a perfect summary of the change. The title is clear enough for a teammate scanning history to see the primary change.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 7382f7e and 72592d7.
Files ignored due to path filters: 1
test/health_workout_export_delete_gate_test.dart is excluded by !test/**
Files selected for processing: 1
lib/health/health_export.dart
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.
Add a test-only constructor override so callers can pin the exporter’s platform selection without changing the production default.
lib/health/health_export.dart L541-548
Implementation
Resolve the effective Apple-platform flag from the override or the real platform, and use it consistently for platform-specific export behavior.
lib/health/health_export.dart L635-639 (+10 small edits)
Tests
Pin the delete-then-write tests to Health Connect so their expectations do not depend on the host operating system.
test/health_workout_export_delete_gate_test.dart L88-189 (8 small edits)
Tips and commands
Interacting with Sourcery
Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Why
health_workout_export_delete_gate_test("a failed delete does not write a duplicate on top of it") fails on every Mac and passes in CI.The
exportWorkout delete-then-writegroup tests the Health Connect reading of afalsedelete, and its comment assumed "the host VM is neither iOS nor macOS". ButHealthExporter.isAppleisPlatform.isIOS || Platform.isMacOS, andflutter teston a Mac runs on a macOS host VM. ThereisAppleis true, the exporter takes the HealthKit branch (where afalsedelete is the documented empty-range answer and the write goes ahead, by design), and the test's Health Connect expectation fails. CI runs onubuntu-latest, so it never sees it; a contributor on a Mac sees a red test unrelated to their change.The app is fine on both platforms. Only the test was host-dependent.
What changes
lib/health/health_export.dart: a@visibleForTesting static bool? isAppleOverride, read first byisApple. null (the default, and always in the app) keeps the real platform check, so production behaviour is unchanged. Same pattern asScreenWake.platformOverrideinlib/gps/screen_wake.dart.test/health_workout_export_delete_gate_test.dart: the group pinsisAppleOverride = falseinsetUpand resets it intearDown, so it tests Health Connect on every host.Tests
test/health_workout_export_delete_gate_test.dart: 11/11 pass on macOS (was 10/11).flutter analyze: no issues.flutter test --concurrency=1: 7010 passed, 28 skipped, 8 failed. The 8 are the ones fix main's test run: missing translations and gallery case #683 fixes (ui2_tokens gallery, russian_localization, russian_review_findings, settings_report_l10n es/fr/hi/zh, thai_l10n); this test is no longer among them.Not related to #683, which fixes the other red tests on main (translations, gallery); this one is a macOS-only failure #683 doesn't cover.
🤖 Generated with Claude Code
Summary by Sourcery
Make Health Connect delete-gate tests platform-independent without changing production behavior.
Bug Fixes:
Enhancements:
Tests:
Summary by CodeRabbit