Skip to content

add pickleball to the activity picker - #651

Merged
abdulsaheel merged 1 commit into
mainfrom
feat/pickleball
Oct 30, 2026
Merged

abdulsaheel merged 1 commit into
mainfrom
feat/pickleball

Conversation

@abdulsaheel

@abdulsaheel abdulsaheel commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

pickleball sessions came in from a WHOOP import but there was no pickleball in the picker, so they showed up as an unknown activity and there was no way to log one by hand.

it sits with the racquet sports. like padel it has no calorie rate, since the compendium the catalogue uses has no pickleball row, so calories come from heart rate. apple health gets its own pickleball workout type; health connect doesn't have one, so it lands as tennis there, same as padel.

Summary by Sourcery

Support pickleball across activity selection, imported workouts, summaries, and health exports.

New Features:

  • Add pickleball as a selectable activity and recognize it in imported WHOOP sessions.

Bug Fixes:

  • Prevent pickleball workouts from appearing as unknown activities and preserve their platform-specific health export mapping.

Enhancements:

  • Classify pickleball with racquet sports and use heart-rate-based calorie estimates when no catalogue MET value is available.

Tests:

  • Add coverage for pickleball catalogue resolution and Apple Health versus Health Connect workout mappings.

Summary by CodeRabbit

  • New Features
    • Added Pickleball to the sports activity catalogue as a duration-tracked activity.
    • Pickleball activity summaries now display the matching sports icon, and activity data can be exported to iOS and Android health services.
    • Added a Russian-language label for Pickleball.

a WHOOP import could bring in pickleball sessions, but the picker had no
pickleball, so they showed as an unknown activity and couldn't be logged by
hand. it sits with the racquet sports, with no calorie rate, like padel.
apple health gets its own pickleball type; health connect has none, so it
lands as tennis there.
@abdulsaheel

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between dcf4a8a and f19f723.

Files ignored due to path filters: 2
  • test/ui2_activity_test.dart is excluded by !test/**
  • test/whoop_activity_type_test.dart is excluded by !test/**
Files selected for processing: 4
  • lib/health/health_export.dart
  • lib/l10n/app_ru.arb
  • lib/ui2/activity/catalogue.dart
  • lib/ui2/activity/summary.dart

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

Pickleball is added to the Sports activity catalogue and match classification. Health exports map it to platform-specific activity names, and the Russian activity catalogue adds a localized label.

Changes: Pickleball activity support

Layer / File(s) Summary
Catalogue and match classification
lib/ui2/activity/catalogue.dart, lib/ui2/activity/summary.dart
The Sports catalogue adds Pickleball as a duration-tracked activity with no MET value. The summary maps it through the match archetype path.
Health export and Russian label
lib/health/health_export.dart, lib/l10n/app_ru.arb
Health export maps pickleball to PICKLEBALL on iOS and TENNIS on Android. Russian localization adds the pickleball label.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Possibly related PRs

  • OpenStrap/edge#643: Updates activity-name normalization and alias mappings for Apple Health and Health Connect exports.

Suggested labels: Review effort 1/5

Suggested reviewers: droptabl, tahir101981-creator

Merge Risk: Minimal · up to f19f7

Pickleball support is consistent across the activity catalogue, health exports, and Russian localization, with no actionable merge risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding pickleball to the activity picker.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Sorry @abdulsaheel, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 5 days and 5 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sourcery-ai

sourcery-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Reviewer's Guide

The PR introduces Pickleball as a first-class activity in the picker and WHOOP-import catalogue, intentionally leaves its calorie rate unset so estimates use heart rate, categorizes it with racquet sports, and exports it as native Pickleball on iOS or Tennis through Health Connect.

Flow diagram for Pickleball activity handling

flowchart LR
    WHOOP[WHOOP import] --> Pickleball[Pickleball activity]
    Picker[Activity picker] --> Pickleball
    Pickleball --> Sports[Sports summary category]
    Pickleball --> HR[Heart-rate calorie estimate]
    Pickleball --> Export[Health export]
    Export -->|iOS| Apple[Apple Health Pickleball]
    Export -->|Health Connect| Tennis[Health Connect Tennis]
Loading

File-Level Changes

Change Details Files
Adds Pickleball as a catalogued, manually selectable activity alongside racquet sports.
  • Registers Pickleball with duration tracking and no MET-based calorie rate.
  • Uses the existing sports summary presentation category.
  • Updates the unpriced-activity expectation to include Pickleball.
lib/ui2/activity/catalogue.dart
lib/ui2/activity/summary.dart
test/ui2_activity_test.dart
Maps pickleball exports to platform-appropriate health workout types.
  • Exports as Apple Health's native PICKLEBALL type on iOS.
  • Falls back to TENNIS for Health Connect, which has no pickleball type.
  • Adds coverage for WHOOP import resolution and both export paths.
lib/health/health_export.dart
test/whoop_activity_type_test.dart
Updates Russian localization resources for the new activity.
  • Adds or adjusts the Russian translation resource associated with Pickleball.
lib/l10n/app_ru.arb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@abdulsaheel

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@abdulsaheel
abdulsaheel merged commit fd99bbc into main Oct 30, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant