Skip to content

Fix images in milestones description #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Stef-Rousset wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix images in milestones description #1304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50dcfb4
fix: display img if added in description
Stef-Rousset Mar 25, 2026
a73a95e
test: check for image if present in milestone description
Stef-Rousset Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion decidim-accountability/app/cells/decidim/accountability/result_show/milestones.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</div>
<% if translated_attribute(milestone.description).present? %>
<div class="editor-content">
<%= decidim_sanitize_translated(milestone.description) %>
<%= decidim_sanitize_admin(translated_attribute(milestone.description)) %>
</div>
<% end %>
</div>
Expand Down
22 changes: 22 additions & 0 deletions decidim-accountability/spec/system/explore_results_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,28 @@
expect(page).to have_content(I18n.l(milestone.entry_date, format: :decidim_short))
expect(page).to have_content(decidim_sanitize_translated(milestone.description))
end

context "and milestone's description contains an image" do
let!(:image_blob) do
ActiveStorage::Blob.create_and_upload!(
io: File.open(Decidim::Dev.asset("city.jpeg")),
filename: "city.jpeg",
content_type: "image/jpeg"
)
end

before do
image_url = Rails.application.routes.url_helpers.rails_blob_path(image_blob, only_path: true)
milestone.update!(description: { "en" => "<p>Milestone description</p><img src=\"#{image_url}\" alt=\"city_image\">" })
end

it "displays the image" do
visit current_path
expect(page).to have_content(decidim_sanitize_translated(milestone.title))
expect(page).to have_content(I18n.l(milestone.entry_date, format: :decidim_short))
expect(page).to have_css(".editor-content img[alt=city_image]")
end
end
end

context "with subresults" do
Expand Down
Loading