Conversation
ufechner7
marked this pull request as draft
July 1, 2026 20:31
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a YAML-exported ram-air kite SystemStructure and updates the example scripts to construct the model by loading that exported YAML instead of generating the structure programmatically.
Changes:
- Added an exported system-structure YAML file for the ram-air kite model under
data/ram_air_kite/. - Updated three example scripts to load
SystemStructurefrom the exported YAML and to load VSM settings fromvsm_settings.yaml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| examples/steering_test_ram_air.jl | Switches system-structure creation to load_sys_struct_from_yaml using exported YAML + VSM settings. |
| examples/ram_air_kite.jl | Same: loads exported YAML system structure (and VSM settings) instead of create_sys_struct. |
| examples/auto_parking_ram_air.jl | Same: loads exported YAML system structure (and VSM settings) instead of create_sys_struct. |
| data/ram_air_kite/ram_air_kite_export.yaml | New exported YAML representation of the ram-air kite system structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ufechner7
marked this pull request as ready for review
July 2, 2026 04:36
1-Bart-1
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.