Skip to content

Add aria labels for badges #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elblinator wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add aria labels for badges #6416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7af6daa
Add label adn aria-disabled=false
Elblinator Jul 16, 2026
beb7002
Clean-up
Elblinator Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions ...omponent-collector/speaker-button/components/speaker-button/speaker-button.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,26 @@
type="button"
[disabled]="disabled"
>
<mat-icon
matBadgeColor="accent"
[matBadge]="
canSee && listOfSpeakers.waitingSpeakerAmount > 0
? listOfSpeakers.waitingSpeakerAmount
: null
"
>
{{ listOfSpeakers.closed ? 'voice_over_off' : 'record_voice_over' }}
</mat-icon>
@if (canSee) {
<mat-icon
matBadgeColor="accent"
[attr.aria-hidden]="false"
[attr.aria-label]="
('Speakers waiting on list of speakers' | translate) +
': ' +
listOfSpeakers.waitingSpeakerAmount
"
[matBadge]="
listOfSpeakers.waitingSpeakerAmount > 0 ? listOfSpeakers.waitingSpeakerAmount : null
"
>
{{ listOfSpeakers.closed ? 'voice_over_off' : 'record_voice_over' }}
</mat-icon>
} @else {
<mat-icon>
{{ listOfSpeakers.closed ? 'voice_over_off' : 'record_voice_over' }}
</mat-icon>
}
</button>
} @else {
<button mat-menu-item type="button">
Expand Down
2 changes: 2 additions & 0 deletions ...ite/pages/meetings/modules/meetings-navigation/meetings-navigation-wrapper.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
matBadgeColor="accent"
matBadgeOverlap="false"
matListItemIcon
[attr.aria-hidden]="false"
[attr.aria-label]="('New messages' | translate) + ': ' + chat.notifications"
[matBadge]="chat.notifications"
[matBadgeHidden]="chat.notifications === 0"
>
Expand Down
2 changes: 2 additions & 0 deletions ...src/app/site/pages/meetings/pages/autopilot/components/autopilot/autopilot.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ <h1 class="mock-h2">
<mat-icon
matBadgeColor="warn"
matBadgeSize="small"
[attr.aria-hidden]="false"
[attr.aria-label]="('Amount of disabled elements' | translate) + ': ' + numDisabledElements"
[matBadge]="numDisabledElements"
[matBadgeHidden]="numDisabledElements < 1"
>
Expand Down
4 changes: 4 additions & 0 deletions ...ages/chat/pages/chat-group-list/components/chat-group-list/chat-group-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ <h1 class="mock-h2" translate>Chat</h1>
class="tab-label-notification-wrapper"
matBadgeColor="accent"
matBadgeOverlap="false"
[attr.aria-hidden]="false"
[attr.aria-label]="
('New messages' | translate) + ': ' + notifications.amount
"
[matBadge]="notifications.amount"
[matBadgeHidden]="!notifications.amount"
></div>
Expand Down
2 changes: 2 additions & 0 deletions ...ings/pages/interaction/modules/action-bar/components/action-bar/action-bar.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@
class="action-bar-shadow background-default"
mat-mini-fab
matTooltip="{{ 'Give applause' | translate }}"
[attr.aria-hidden]="false"
[attr.aria-label]="('Amount of applause' | translate) + ': ' + (applauseLevel | async)"
[disabled]="sendsApplause | async"
[matBadge]="applauseLevel | async"
[matBadgeHidden]="(showApplauseLevel | async) === false"
Expand Down
4 changes: 4 additions & 0 deletions ...otions/pages/motion-call-list/components/motion-call-list/motion-call-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ <h1 class="mock-h2" translate>Call list</h1>
<span
class="upper badge-space"
matBadgeColor="accent"
[attr.aria-hidden]="false"
[attr.aria-label]="('Amount of filtered categories' | translate) + ': ' + activeCatFilterCount"
[matBadge]="activeCatFilterCount > 0 ? activeCatFilterCount : null"
[matBadgeOverlap]="false"
>
Expand All @@ -49,6 +51,8 @@ <h1 class="mock-h2" translate>Call list</h1>
<span
class="upper badge-space"
matBadgeColor="accent"
[attr.aria-hidden]="false"
[attr.aria-label]="('Amount of filtered Tags' | translate) + ': ' + activeTagFilterCount"
[matBadge]="activeTagFilterCount > 0 ? activeTagFilterCount : null"
[matBadgeOverlap]="false"
>
Expand Down
7 changes: 6 additions & 1 deletion ...tion-view/components/motion-detail-diff-summary/motion-detail-diff-summary.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
<!-- A summary of all changes -->
@if (changes?.length) {
<div class="change-recommendation-summary outlined-border">
<strong matBadgeOverlap="false" [matBadge]="changes.length">
<strong
matBadgeOverlap="false"
[attr.aria-hidden]="false"
[attr.aria-label]="('Amount of changes' | translate) + ': ' + changes.length"
[matBadge]="changes.length"
>
{{ 'Summary of changes' | translate }}&nbsp;
</strong>
<cdk-virtual-scroll-viewport
Expand Down
4 changes: 4 additions & 0 deletions ...eetings/pages/motions/pages/motion-list/components/motion-list/motion-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ <h1 class="mock-h2" translate>Motions</h1>
<div class="flex-center background-selected">
<span
class="tile-content-prefix"
[attr.aria-hidden]="false"
[attr.aria-label]="
('Amount of motions in category' | translate) + ': ' + tile.amountOfMotions
"
[matBadge]="tile.amountOfMotions"
[matBadgeColor]="'accent'"
>
Expand Down
4 changes: 4 additions & 0 deletions ...ges/committees/modules/committee-meeting-preview/committee-meeting-preview.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@
<ng-template #canNotManageUsersTemplate>
<div class="fake-button-no-touch" matTooltip="{{ userAmount }} {{ 'participants' | translate }}">
<mat-icon
[attr.aria-hidden]="false"
[attr.aria-label]="('Number of participants' | translate) + ' ' + userAmount"
[class.smaller-badge-text]="shouldUseSmallerBadgeText"
[matBadge]="formattedUserAmount"
[matBadgeColor]="'accent'"
Expand All @@ -119,6 +121,8 @@
(click)="changeToMeetingUsers()"
>
<mat-icon
[attr.aria-hidden]="false"
[attr.aria-label]="('Number of participants' | translate) + ' ' + userAmount"
[class.smaller-badge-text]="shouldUseSmallerBadgeText"
[matBadge]="formattedUserAmount"
[matBadgeColor]="'accent'"
Expand Down
14 changes: 13 additions & 1 deletion client/src/app/ui/modules/list/components/sort-filter-bar/sort-filter-bar.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</button>
</div>
}
@for (filter of filterService?.filterStack || []; track filter) {
@for (filter of filterService?.filterStack || []; track filter.option) {
<div>
<button
mat-stroked-button
Expand Down Expand Up @@ -54,6 +54,10 @@
matBadge="&#8288;"
matBadgeColor="accent"
matBadgeSize="small"
[attr.aria-hidden]="false"
[attr.aria-label]="
hasSortOptionSelected ? ('active custom sort' | translate) : ('default sort' | translate)
"
[matBadgeHidden]="!hasSortOptionSelected"
[matBadgeOverlap]="false"
>
Expand All @@ -68,6 +72,10 @@
matBadge="&#8288;"
matBadgeColor="accent"
matBadgeSize="small"
[attr.aria-hidden]="false"
[attr.aria-label]="
hasSortOptionSelected ? ('active custom sort' | translate) : ('default sort' | translate)
"
[matBadgeHidden]="!hasSortOptionSelected"
[matBadgeOverlap]="false"
>
Expand All @@ -87,6 +95,8 @@
<mat-icon
matBadgeColor="accent"
matBadgeSize="small"
[attr.aria-hidden]="false"
[attr.aria-label]="('Amount of active filters' | translate) + ': ' + filterAmount"
[matBadge]="filterAmount"
[matBadgeHidden]="filterAmount === 0 || (vp.isMobileSubject | async) === false"
[matBadgeOverlap]="false"
Expand All @@ -98,6 +108,8 @@
class="upper"
matBadgeColor="accent"
matBadgeSize="small"
[attr.aria-hidden]="false"
[attr.aria-label]="('Amount of active filters' | translate) + ': ' + filterAmount"
[matBadge]="filterAmount"
[matBadgeHidden]="filterAmount === 0"
[matBadgeOverlap]="false"
Expand Down
Loading