Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new tuner feature to the audio amplifier application, implementing pitch detection and a GUI display. The tuner uses the AMDF (Average Magnitude Difference Function) algorithm to detect fundamental frequencies and displays note information, frequency, and tuning accuracy.
- Implements a new
Tunerstruct with AMDF pitch detection algorithm - Adds tuner integration to the audio processing pipeline with real-time frequency analysis
- Creates a comprehensive tuner dialog interface with visual feedback for tuning accuracy
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sim/tuner.rs | New tuner implementation with AMDF pitch detection and note conversion |
| src/sim/mod.rs | Exports the new tuner module |
| src/io/processor.rs | Integrates tuner into audio processing pipeline with sample feeding and info updates |
| src/io/manager.rs | Adds tuner management with channel communication and enable/disable controls |
| src/gui/messages.rs | Adds tuner-related message types for UI interaction |
| src/gui/components/mod.rs | Reorganizes component structure to include dialogs module |
| src/gui/components/dialogs/tuner.rs | Comprehensive tuner display with visual pitch indicator and status feedback |
| src/gui/components/dialogs/mod.rs | Module declaration for dialog components |
| src/gui/app.rs | Integrates tuner dialog into main application with subscription-based updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
The screens can now be completely refactored, so that we don't use "dialogs" going forwards