Skip to content

Add Tuner - #68

Merged
OpenSauce merged 6 commits into
mainfrom
add-tuner
Oct 18, 2025
Merged

Add Tuner#68
OpenSauce merged 6 commits into
mainfrom
add-tuner

Conversation

@OpenSauce

Copy link
Copy Markdown
Owner

Closes #28

The screens can now be completely refactored, so that we don't use "dialogs" going forwards

Copilot AI review requested due to automatic review settings October 18, 2025 14:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new tuner feature to the audio amplifier application, implementing pitch detection and a GUI display. The tuner uses the AMDF (Average Magnitude Difference Function) algorithm to detect fundamental frequencies and displays note information, frequency, and tuning accuracy.

  • Implements a new Tuner struct with AMDF pitch detection algorithm
  • Adds tuner integration to the audio processing pipeline with real-time frequency analysis
  • Creates a comprehensive tuner dialog interface with visual feedback for tuning accuracy

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/sim/tuner.rs New tuner implementation with AMDF pitch detection and note conversion
src/sim/mod.rs Exports the new tuner module
src/io/processor.rs Integrates tuner into audio processing pipeline with sample feeding and info updates
src/io/manager.rs Adds tuner management with channel communication and enable/disable controls
src/gui/messages.rs Adds tuner-related message types for UI interaction
src/gui/components/mod.rs Reorganizes component structure to include dialogs module
src/gui/components/dialogs/tuner.rs Comprehensive tuner display with visual pitch indicator and status feedback
src/gui/components/dialogs/mod.rs Module declaration for dialog components
src/gui/app.rs Integrates tuner dialog into main application with subscription-based updates

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/sim/tuner.rs
Comment thread src/io/processor.rs
Comment thread src/gui/app.rs Outdated
Comment thread src/gui/components/dialogs/tuner.rs Outdated
@OpenSauce
OpenSauce enabled auto-merge (squash) October 18, 2025 14:20
@OpenSauce
OpenSauce merged commit 3472933 into main Oct 18, 2025
2 checks passed
@OpenSauce
OpenSauce deleted the add-tuner branch October 18, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a Tuner

2 participants