Remove CLI - #37
Merged
Merged
Conversation
OpenSauce
marked this pull request as ready for review
July 19, 2025 19:59
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the CLI binary from the project, focusing solely on the GUI interface. The changes simplify the AmplifierChain API by removing the name parameter and eliminate the CLI-specific example code.
- Removed CLI binary configuration from Cargo.toml
- Simplified AmplifierChain constructor to remove unused name parameter
- Removed extensive Mesa Boogie Dual Rectifier configuration example code
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Removed CLI binary target configuration |
| src/sim/chain.rs | Simplified AmplifierChain constructor and removed example amplifier configuration |
| src/io/processor.rs | Updated AmplifierChain instantiation to use new constructor |
| src/gui/app.rs | Updated AmplifierChain instantiation to use new constructor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.