Skip to content

Use default font - #35

Merged
OpenSauce merged 2 commits into
mainfrom
use-default-font
Jul 19, 2025
Merged

Use default font#35
OpenSauce merged 2 commits into
mainfrom
use-default-font

Conversation

@OpenSauce

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 19, 2025 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the use of a default font throughout the application by centralizing font configuration. The change moves font configuration from individual widget calls to a single application-level setting.

  • Moved the ICONS_FONT constant from src/gui/components/mod.rs to src/gui/mod.rs
  • Set the default font globally using .default_font() in the application configuration
  • Removed explicit font specifications from individual button and text widgets

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/gui/mod.rs Added ICONS_FONT constant and configured default font for the application
src/gui/components/mod.rs Removed the ICONS_FONT constant definition
src/gui/components/widgets/common.rs Removed explicit font specification from icon_button function
src/gui/components/control.rs Removed explicit font specifications from recording control buttons
Comments suppressed due to low confidence (1)

src/gui/mod.rs:12

  • The constant name ICONS_FONT is misleading since it's now being used as the default font for the entire application, not just icons. Consider renaming it to DEFAULT_FONT or APP_FONT to better reflect its purpose.
pub const ICONS_FONT: Font = Font::MONOSPACE;

@OpenSauce
OpenSauce enabled auto-merge (squash) July 19, 2025 16:00
@OpenSauce
OpenSauce disabled auto-merge July 19, 2025 16:00
@OpenSauce
OpenSauce enabled auto-merge (squash) July 19, 2025 16:01
@OpenSauce
OpenSauce merged commit 043fdcd into main Jul 19, 2025
2 checks passed
@OpenSauce
OpenSauce deleted the use-default-font branch July 19, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants