Use default font - #35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the use of a default font throughout the application by centralizing font configuration. The change moves font configuration from individual widget calls to a single application-level setting.
- Moved the ICONS_FONT constant from
src/gui/components/mod.rstosrc/gui/mod.rs - Set the default font globally using
.default_font()in the application configuration - Removed explicit font specifications from individual button and text widgets
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gui/mod.rs | Added ICONS_FONT constant and configured default font for the application |
| src/gui/components/mod.rs | Removed the ICONS_FONT constant definition |
| src/gui/components/widgets/common.rs | Removed explicit font specification from icon_button function |
| src/gui/components/control.rs | Removed explicit font specifications from recording control buttons |
Comments suppressed due to low confidence (1)
src/gui/mod.rs:12
- The constant name ICONS_FONT is misleading since it's now being used as the default font for the entire application, not just icons. Consider renaming it to DEFAULT_FONT or APP_FONT to better reflect its purpose.
pub const ICONS_FONT: Font = Font::MONOSPACE;
OpenSauce
enabled auto-merge (squash)
July 19, 2025 16:00
OpenSauce
disabled auto-merge
July 19, 2025 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.