Enable recording - #34
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements recording functionality by refactoring the processor communication system to use a unified message enum and integrating a recorder component. The changes enable starting and stopping audio recordings through the processor manager.
- Refactors processor communication from direct amplifier chain updates to a message-based system using
ProcessorMessageenum - Integrates recording functionality with start/stop methods in
ProcessorManager - Reduces audio block frame size from 256 to 128 for improved recording latency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/io/recorder.rs | Reduces BLOCK_FRAMES constant from 256 to 128 |
| src/io/processor.rs | Introduces ProcessorMessage enum and refactors message handling |
| src/io/manager.rs | Implements recording start/stop functionality and updates communication channel |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16