Add Recording Controls to GUI - #32
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds GUI controls and backend hooks to manage audio recording state without enabling recording by default.
- ProcessorManager now accepts an optional
Recorderand provides a stubbedenable_recordingmethod. - New
StartRecording/StopRecordingmessages and UI buttons with status indicator in the Control widget. - AmplifierApp state and message handling updated to wire recording commands to the processor manager.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/io/manager.rs | Updated ProcessorManager::new signature and stubbed out enable_recording |
| src/gui/messages.rs | Added StartRecording and StopRecording message variants |
| src/gui/components/widgets/common.rs | Removed local ICONS_FONT and imported from the shared constant |
| src/gui/components/mod.rs | Introduced global ICONS_FONT constant |
| src/gui/components/control.rs | Added record/stop buttons and status text to the Control layout |
| src/gui/app.rs | Added is_recording state, message handlers for recording, and passed flag to Control |
Comments suppressed due to low confidence (2)
src/io/manager.rs:60
- Consider adding unit tests for
enable_recording(and the eventualdisable_recording) to verify that the recorder state transitions are handled correctly.
pub fn enable_recording(&mut self) -> Result<()> {
src/io/manager.rs:66
- There is no
disable_recordingmethod inProcessorManager, yet the GUI calls it. Implementdisable_recording(&mut self)to properly stop and drop the recorder.
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording is still disabled whilst I figure out the best way to communicate between threads