fix(browser/cdp): compile against chromedp v0.13.6#206
Merged
Conversation
- target.SetAutoAttach now takes 2 arguments (autoAttach, flatten). - security.EventSecurityStateChanged, page download events, and target.RunIfWaitingForDebugger are not present in v0.13.6. - chromedp.WithExistingSession was removed; child-session enablement is deferred. - go mod tidy adds the missing indirect sums so the package builds.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🏆 CEO Audit — A+ (100.0/100)
📥 Download full report (Markdown)
|
🏆 CEO Audit — A+ (100.0/100)
📥 Download full report (Markdown) Run ID:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #201 introduced the native CDP recorder, but the code was written against an older chromedp/cdproto API and would not build with the v0.13.6 version declared in go.mod.\n\nThis fix:\n- Uses target.SetAutoAttach(autoAttach, flatten) (2 args).\n- Removes references to events/symbols not present in v0.13.6.\n- Defers child-session enablement until the package is exercised with a browser.\n- Runs go mod tidy to add the missing go.sum entries.\n\nThe package now builds and the root cmd/sin-code test suite passes.