front: fix simple oxlint violations by Signez · Pull Request #18456 · OpenRailAssociation/osrd

Signez · 2026-09-07T09:27:10Z

We have a very long list of rules that we disable in .oxlintrc.json. Those settings were grandfathered from some old eslint configuration, but it's quite beneficial to reduce this list, as those lints can find actual code smells!

In this pull request, I fix 15 ones that I deemed both uncontroversial and easy to fix. A commit-by-commit review is highly recommanded: each commit contains the name of the lint being re-enabled.

I started from the rules that had the least number of violations in our codebase, but there are still 55 rules left after this pull request, some more controversial, but most of them still uncontroversial but with way more violations.

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

Note that we need to await on `act` even though its signature looks like it's not awaitable; it's because TS do not understand that it *can* (and should) be awaited depending on React's version. Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

Synar

Thanks for fixing all these issues!

Synar · 2026-09-07T10:05:23Z

@@ -48,7 +48,7 @@ function getConflictTrainNames(
      // Otherwise, the name is `${pacedTrainName}/+`
      const namedException = trainSchedule.paced.exceptions.find(
        // TODO_EXCEPTION: remove `!` when using TrainSchedulingException type


I believe this TODO can now be dropped

Synar · 2026-09-07T10:12:57Z


 const withControlledValue: Decorator = (Story, ctx) => {
-  const [value, setValue] = useState<string>(String(ctx.args.value ?? ''));
+  const [value, setValue] = useState<string>(String((ctx.args.value as string) ?? ''));


Can't we drop String here?

Synar · 2026-09-07T10:22:48Z

            <span className="mr-3">
              {((schema.properties || {})[k] as JSONSchema7 | undefined)?.title || k}
            </span>
+            {/* oxlint-disable-next-line typescript/no-base-to-string */}


I believe you can get rid of this disable by changing the unkwown in LinearMetadataTooltip signature to string | number (which should be the only values allowed by LinearMetadataItem, so no loss of generality).

Woah, good catch indeed! Thanks for that, I wouldn't have thought about that 👍

Synar · 2026-09-07T10:25:07Z

          </div>
          <div>at: {hovered.point.at}</div>
+          {/* eslint-disable-next-line typescript/no-base-to-string */}
          <div>caused by: {hovered.point.source?.toString()}</div>


Shouldn't this be a JSON.stringify instead?

I didn't dug because it was in DebugMap, but indeed, a JSON-stringified version is good enough 👍

Synar · 2026-09-07T10:25:47Z

  if (value === '') return null;

+  /* eslint-disable-next-line typescript/no-base-to-string */
  const stringValue = `${value}`;


Perhaps this should also be a JSON.stringify instead

Synar · 2026-09-07T10:41:04Z

    "prefer-nullish-coalescing": "off",
    "prefer-readonly-parameter-types": "off",
    "prefer-tag-over-role": "off",
-    "radix": "off",


I'm unconvinced this rule is useful to us, though I guess trimming this list is nice

emersion · 2026-09-07T10:04:47Z

@@ -48,7 +48,7 @@ function getConflictTrainNames(
      // Otherwise, the name is `${pacedTrainName}/+`
      const namedException = trainSchedule.paced.exceptions.find(
        // TODO_EXCEPTION: remove `!` when using TrainSchedulingException type


We should remove the TODO as well, I think.

emersion · 2026-09-07T10:21:52Z


 const withControlledValue: Decorator = (Story, ctx) => {
-  const [value, setValue] = useState<string>(String(ctx.args.value ?? ''));
+  const [value, setValue] = useState<string>(String((ctx.args.value as string) ?? ''));


Hm, unfortunately it doesn't seem like React.InputHTMLAttributes.value field is specialized based on the input type… I would argue that we should Omit the value field from TextAreaProps and set it explicitly as a string to avoid irrelevant types such as number and string[]. That sounds all orthogonal to this PR though.

If we cast to string here, then we don't need to pass the result to String(): it's already a string. ?? '' is also unnecessary according to the expression's type. Either the cast should be as (string | undefined), or the cast should be on the result of value ?? ''.

Fully agree. I don't think we could have undefined here in runtime, so let's simplify it as useState<string>(ctx.args.value as string) which makes sense in such a Storybook's story.

emersion · 2026-09-07T10:28:51Z

+  Top = 0,
+  Bottom = 1,
+  Left = 2,
+  Right = 3,


Ah, these originate from NGE. We should no longer need this file, see #18458.

emersion · 2026-09-07T10:32:06Z

      ))
    );

+    /* eslint-disable-next-line typescript/await-thenable */


Since we're using a locked and recent React version, I don't think we'll ever run into the Promise version of this?

Yohh · 2026-09-07T09:32:55Z

@@ -48,7 +48,7 @@ function getConflictTrainNames(
      // Otherwise, the name is `${pacedTrainName}/+`
      const namedException = trainSchedule.paced.exceptions.find(
        // TODO_EXCEPTION: remove `!` when using TrainSchedulingException type


this TODO has lost its sense

Signez requested review from Yohh and emersion September 7, 2026 09:27

Signez self-assigned this Sep 7, 2026

Signez requested review from a team as code owners September 7, 2026 09:27

Signez added area:front Work on Standard OSRD Interface modules kind:technical-enhancement area:ui Work on UI labels Sep 7, 2026

Signez added this to Board PI 21 Sep 7, 2026

github-actions Bot deployed to storybook September 7, 2026 09:29 View deployment

Base automatically changed from stan/prune-oxlint-exceptions to dev September 7, 2026 10:21

Signez added 15 commits September 7, 2026 12:21

ui: fix no-lonely-if linter violations

11d339e

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front: fix no-unsafe-optional-chaining lint violation

f8b610a

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front: fix no-confusing-non-null-assertion lint violation

0a89c39

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front: fix no-duplicate-type-constituents lint violation

7a11f40

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front: fix prefer-includes lint violation

ebbcf16

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front: fix no-useless-constructor lint violations

23e2b2d

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front: fix preserve-caught-error lint violations

9be34c4

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front, ui: fix no-base-to-string lint violations

34314f5

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front: fix require-array-sort-compare lint violations

810f49a

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front, ui: fix prefer-enum-initializers lint violations

0947139

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front, ui: fix radix rule violations

82543f8

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front: fix no-unnecessary-boolean-literal-compare lint violations

29ee5b5

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front, ui: fix no-unnecessary-type-arguments lint violations

3e6ef59

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

front, ui: fix no-unnecessary-template-expression lint violations

3de0043

Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>

Signez force-pushed the stan/fix-simple-oxlint-violations branch from bf40d22 to 3de0043 Compare September 7, 2026 10:21

Synar approved these changes Sep 7, 2026

View reviewed changes

emersion reviewed Sep 7, 2026

View reviewed changes

Yohh approved these changes Sep 7, 2026

View reviewed changes

Uh oh!

Conversation

Signez commented Sep 7, 2026

Uh oh!

Synar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Signez Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Signez Sep 7, 2026 •

edited

Loading