Skip to content

clean up ui-charts css - #18365

Merged
Uriel-Sautron merged 6 commits into
devfrom
usn/clean-css-ui-charts
Sep 7, 2026
Merged

clean up ui-charts css#18365
Uriel-Sautron merged 6 commits into
devfrom
usn/clean-css-ui-charts

Conversation

@Uriel-Sautron

@Uriel-Sautron Uriel-Sautron commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

close #18364

cleanup css in ui-charts:

  • fixed CSS variables in speedSpaceChart
  • introduced a shared --shadow-charts variable to remove duplicated box-shadows
  • enforced the rem (font-size) / px (everything else) convention across the remaining files

@Uriel-Sautron
Uriel-Sautron requested review from Math-R and Yohh September 1, 2026 13:34
@Uriel-Sautron
Uriel-Sautron requested a review from a team as a code owner September 1, 2026 13:34
@github-actions github-actions Bot added area:front Work on Standard OSRD Interface modules area:ui Work on UI labels Sep 1, 2026
Math-R
Math-R reviewed Sep 1, 2026
View reviewed changes
Comment thread front/ui/ui-charts/src/chronogram/styles/main.css Outdated
Math-R
Math-R reviewed Sep 1, 2026
View reviewed changes
Comment thread front/ui/ui-charts/src/manchette/styles/waypoint.css Outdated
@Uriel-Sautron
Uriel-Sautron force-pushed the usn/clean-css-ui-charts branch from d874cda to 6eae6d5 Compare September 1, 2026 14:23
@Uriel-Sautron
Uriel-Sautron requested a review from Math-R September 1, 2026 14:37
Math-R
Math-R approved these changes Sep 2, 2026
View reviewed changes

@Math-R Math-R left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Yohh
Yohh reviewed Sep 7, 2026
View reviewed changes
Comment thread front/ui/ui-charts/src/common/styles/index.css
Comment thread front/ui/ui-charts/src/speedSpaceChart/styles/main.css Outdated
Comment thread front/ui/ui-charts/src/manchette/styles/menu.css Outdated
Comment thread front/ui/ui-charts/src/manchette/styles/menu.css Outdated
@Uriel-Sautron
front: ui-charts: create common css variable for charts shadow
4ffc923 
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
@Uriel-Sautron
Uriel-Sautron force-pushed the usn/clean-css-ui-charts branch from 6eae6d5 to 0902fe7 Compare September 7, 2026 13:19
@Uriel-Sautron
front: ui-charts: clean speed space chart styles
23f88f5 
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
@Uriel-Sautron
front: ui-charts: clean waypoint style
69be135 
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
@Uriel-Sautron
front: ui-charts: clean trackOccupancyDiagram style
1d335ba 
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
@Uriel-Sautron
front: ui-charts: clean manchette style
88c2048 
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
@Uriel-Sautron
front: ui-charts: clean chronogram style
c94656b 
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
@Uriel-Sautron
Uriel-Sautron force-pushed the usn/clean-css-ui-charts branch from 0902fe7 to c94656b Compare September 7, 2026 14:06
@Uriel-Sautron
Uriel-Sautron added this pull request to the merge queue Sep 7, 2026
Merged via the queue into dev with commit d19dfdc Sep 7, 2026
40 checks passed
@Uriel-Sautron
Uriel-Sautron deleted the usn/clean-css-ui-charts branch September 7, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yohh Yohh Yohh approved these changes
@Math-R Math-R Math-R approved these changes

Assignees

No one assigned

Labels

area:front Work on Standard OSRD Interface modules area:ui Work on UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean UI-charts CSS

3 participants

@Uriel-Sautron @Yohh @Math-R