Skip to content

front: guard times-stops arrival interpolation against stale simulation data - #17775

Merged
Akctarus merged 1 commit into
devfrom
tmn/front/fix-times-stops-interpolation-race
Aug 26, 2026
Merged

front: guard times-stops arrival interpolation against stale simulation data#17775
Akctarus merged 1 commit into
devfrom
tmn/front/fix-times-stops-interpolation-race

Conversation

@Akctarus

@Akctarus Akctarus commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

closes #17487

@Akctarus
Akctarus requested a review from a team as a code owner July 22, 2026 12:55
@Akctarus
Akctarus force-pushed the tmn/front/fix-times-stops-interpolation-race branch from 074fd95 to 222b9c1 Compare July 22, 2026 12:55
@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label Jul 22, 2026

@emersion emersion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit fragile to me. If the data is stale but still within range, then this will give incorrect results.

We have data desync issues in many places. I'd prefer to go for a more general approach to fix this. #16219 is similar and contains some hints to fix it.

@Akctarus

Copy link
Copy Markdown
Contributor Author

This seems a bit fragile to me. If the data is stale but still within range, then this will give incorrect results.

We have data desync issues in many places. I'd prefer to go for a more general approach to fix this. #16219 is similar and contains some hints to fix it.

I think c10ab13 should fix it

@Akctarus
Akctarus requested review from Pivouane and emersion July 22, 2026 15:58
Comment thread front/src/modules/timesStops/hooks/useTimesStopsTableData.ts Outdated
Comment thread front/src/modules/timesStops/hooks/useTimesStopsTableData.ts Outdated
Comment thread front/src/modules/timesStops/hooks/useTimesStopsTableData.ts Outdated

@Pivouane Pivouane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🐴

@Akctarus
Akctarus requested a review from emersion August 24, 2026 13:15
…on data

Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus
Akctarus force-pushed the tmn/front/fix-times-stops-interpolation-race branch from 89c94e7 to d36ad71 Compare August 26, 2026 07:54
@Akctarus
Akctarus enabled auto-merge August 26, 2026 07:54
@Akctarus
Akctarus added this pull request to the merge queue Aug 26, 2026
Merged via the queue into dev with commit 0d38b35 Aug 26, 2026
38 checks passed
@Akctarus
Akctarus deleted the tmn/front/fix-times-stops-interpolation-race branch August 26, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Whitepage when changing the rolling stock from the schedule sheet header (in some cases)

3 participants