Skip to content

adjust images, remove blur - #20

Merged
OebbJan merged 11 commits into
mainfrom
adjust-images
Feb 28, 2026
Merged

adjust images, remove blur#20
OebbJan merged 11 commits into
mainfrom
adjust-images

Conversation

@OebbJan

@OebbJan OebbJan commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown
Pull Request Live Preview


❌ Preview has been removed.

@OebbJan

OebbJan commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

@mxmehl looks like the images are scaled down and become pixellated - do you know why? The main image is an 8MB large image in this version, should not appear pixellated as is the case now...
CleanShot 2026-02-24 at 16 25 28@2x

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to give these new files more telling names.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is HUGE! Also, it's more or less the same as another file that already exists in the tree, which has similar dimensions but is only 2MB. Consider dropping this altogether.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't seem to be used.

{{- /* Expects .image (asset), optionally .processes and .filter */}}
{{- $image := .image }}
{{- with (resources.Get .image) }}
{{- $image = (resources.Get $image).Fill "1200x630 Center" }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This here was the fix for the pixelated image. Stupid bug, sorry.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks for fixing - looks great now!

@mxmehl mxmehl removed their assignment Feb 27, 2026
@OebbJan
OebbJan merged commit ade2550 into main Feb 28, 2026
2 checks passed
@OebbJan
OebbJan deleted the adjust-images branch February 28, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants