Repository navigation
macOS: pass command-line arguments through run_phd2_macos - #1471
Merged
Merged
Conversation
open -a PHD2.app --args -i 2 started instance 1: the bundle launcher dropped its arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_phd2_macos(the bundle'sCFBundleExecutable) ends withexec "$HERE"/PHD2without"$@", so arguments given through LaunchServices never reach PHD2.open -n -a PHD2.app --args -i 2starts instance 1 instead of instance 2.This passes them on.
Tested on macOS 26.6.2, Apple M5 Max, built on top of #1453:
open -n -a PHD2.app --args -i 9started PHD2 with no arguments (event server on 4400).-i 9and listens on 4408.