Repository navigation
Open OpenMouse without blocking the Windows panel - #71
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The Open OpenMouse button now uses GPUI's URL opener instead of custom platform launch code, retaining the same HTTPS destination. The change is confined to a user-initiated browser launch and does not alter service behavior or stored data. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Routes the Open OpenMouse button through GPUI’s platform URL opener. On Windows, GPUI launches the shell target on its background executor, so the native shell call no longer runs inside the panel click callback. Removes the duplicate synchronous URL opener. Verification: cargo fmt --check and cargo check --locked locally; platform CI and artifact builds running.
Note
Open OpenMouse via GPUI URL API instead of blocking
runtime::open_openmouseThe OpenMouse button in panel.rs now calls GPUI's URL-opening API with a panel-local
OPENMOUSE_URLconstant. This removes theruntime::open_openmousewrapper, the platform-specificopen_urlimplementations, and the Windows UTF-16 URL-encoding helper from runtime.rs. Risk: ShellExecuteW-based Windows opening is removed; check that GPUI's URL-opening API handles the Windows panel case correctly.Macroscope summarized bf624f1.