Skip to content

Open OpenMouse without blocking the Windows panel - #71

Merged
snekxs merged 1 commit into
mainfrom
fix/windows-open-openmouse
Nov 4, 2026
Merged

snekxs merged 1 commit into
mainfrom
fix/windows-open-openmouse

Conversation

@snekxs

@snekxs snekxs commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Routes the Open OpenMouse button through GPUI’s platform URL opener. On Windows, GPUI launches the shell target on its background executor, so the native shell call no longer runs inside the panel click callback. Removes the duplicate synchronous URL opener. Verification: cargo fmt --check and cargo check --locked locally; platform CI and artifact builds running.

Note

Open OpenMouse via GPUI URL API instead of blocking runtime::open_openmouse

The OpenMouse button in panel.rs now calls GPUI's URL-opening API with a panel-local OPENMOUSE_URL constant. This removes the runtime::open_openmouse wrapper, the platform-specific open_url implementations, and the Windows UTF-16 URL-encoding helper from runtime.rs. Risk: ShellExecuteW-based Windows opening is removed; check that GPUI's URL-opening API handles the Windows panel case correctly.

Macroscope summarized bf624f1.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between f1d9434 and bf624f1.

Files selected for processing: 2
  • src/gpui_shell/panel.rs
  • src/runtime.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the area: native Native bridge and platform services label Nov 4, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 4, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at bf624f1

Macroscope's review found this PR approvable — The Open OpenMouse button now uses GPUI's URL opener instead of custom platform launch code, retaining the same HTTPS destination. The change is confined to a user-initiated browser launch and does not alter service behavior or stored data.

Notes:

  • Your repo's Minimum Blocking Severity is Off, so correctness findings do not automatically block approval.

You can add or adjust custom eligibility rules. Learn more.

@snekxs
snekxs merged commit aab8622 into main Nov 4, 2026
11 checks passed
@snekxs
snekxs deleted the fix/windows-open-openmouse branch November 4, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: native Native bridge and platform services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant