Skip to content

Make rmSync failure non-fatal #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnHeuermann merged 6 commits into from
Mar 2, 2026
Merged

Make rmSync failure non-fatal #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e172de7
Make rmSync failure non-fatal
AnHeuermann Mar 2, 2026
d8e93c4
Adding more OpenModelica versions
AnHeuermann Mar 2, 2026
a52a22b
Bump npm dev dependencies to latest patch versions (#468)
AnHeuermann Mar 2, 2026
07dbc8e
Updating actions/upload-artifact@v7
AnHeuermann Mar 2, 2026
4e1605d
Keep tmp director in workspace to keep caching working
AnHeuermann Mar 2, 2026
5db03f8
Don't delete finished download on error
AnHeuermann Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-dist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
id: diff

# If index.js was different than expected, upload the expected version as an artifact
- uses: actions/upload-artifact@v6
- uses: actions/upload-artifact@v7
if: ${{ failure() && steps.diff.conclusion == 'failure' }}
with:
name: dist
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,6 @@ lib/**/*

# Ignore VS Code settings
.vscode/

# Ignore LLM settings
.claude/
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ Afterwards the OpenModelica Package manager installs Modelica libraries.
| nightly | Linux | amd64, arm64, armhf, i386 | ✔️ |
| stable | Linux | amd64, arm64, armhf, i386 | ✔️ |
| release | Linux | amd64, arm64, armhf, i386 | ✔️ |
| 1.26.3 | Linux | amd64, arm64, armhf, i386 | ✔️ |
| 1.26.2 | Linux | amd64, arm64, armhf, i386 | ✔️ |
| 1.26.1 | Linux | amd64, arm64, armhf, i386 | ✔️ |
| 1.26.0 | Linux | amd64, arm64, armhf, i386 | ✔️ |
| 1.25.7 | Linux | amd64, arm64, armhf, i386 | ✔️ |
Expand Down Expand Up @@ -85,6 +87,8 @@ Afterwards the OpenModelica Package manager installs Modelica libraries.
| nightly | Windows | 64bit | ✔️ |
| stable | Windows | 64bit | ✔️ |
| release | Windows | 64bit | ✔️ |
| 1.26.3 | Windows | 64bit | ✔️ |
| 1.26.2 | Windows | 64bit | ✔️ |
| 1.26.1 | Windows | 64bit | ✔️ |
| 1.26.0 | Windows | 64bit | ✔️ |
| 1.25.7 | Windows | 64bit | ✔️ |
Expand Down
16 changes: 8 additions & 8 deletions __tests__/installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function linuxTests(): void {
let outVer: installer.VersionType

outVer = installer.getOMVersion('1')
expect(outVer.version).toEqual('1.26.1')
expect(outVer.version).toEqual('1.26.3')

outVer = installer.getOMVersion('1.18')
expect(outVer.version).toEqual('1.18.1')
Expand All @@ -70,13 +70,13 @@ function linuxTests(): void {
})

test(
'Install 64 bit OpenModelica release 1.26.1',
'Install 64 bit OpenModelica release 1.26.3',
async () => {
await purgeOMC()
const version = installer.getOMVersion('1.26.1')
const version = installer.getOMVersion('1.26.3')
await installer.installOM(['omc'], version, '64')
const resVer = await installer.showVersion('omc')
expect(resVer).toEqual('1.26.1')
expect(resVer).toEqual('1.26.3')
},
10 * 60000
)
Expand Down Expand Up @@ -171,13 +171,13 @@ function linuxTests(): void {
*/
function windowsTests(): void {
test(
'Install 64 bit OpenModelica release 1.26.1',
'Install 64 bit OpenModelica release 1.26.3',
async () => {
const version = installer.getOMVersion('1.26.1')
expect(version.version).toEqual('1.26.1')
const version = installer.getOMVersion('1.26.3')
expect(version.version).toEqual('1.26.3')
await installer.installOM(['omc'], version, '64')
const resVer = await installer.showVersion('omc')
expect(resVer).toContain('1.26.1')
expect(resVer).toContain('1.26.3')
},
60 * 60000
)
Expand Down
Loading
Loading