Change branch condition in setStartValues - #1634
Open
AxelMatstoms wants to merge 1 commit into
Open
Conversation
The SSP standard allows empty SSM files. When an SSM is present, no values except those in the SSM should be applied. This behavior corresponds to the first branch in setStartValues. Previously the condition in this if statement was `ssm and ssm.mappingEntry`. This means empty SSM files caused the other branch to be selected. This is contrary to what the standard requires. Using `ssm is not None` instead ensures compliance to the SSP standard.
AxelMatstoms
force-pushed
the
handle-empty-ssm
branch
from
August 25, 2026 12:32
1676465 to
8f03078
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#1628
Purpose
The SSP standard allows empty SSM files. When an SSM is present, no values except those in the SSM should be applied. This behavior corresponds to the first branch in setStartValues. Previously the condition in this if statement was
ssm and ssm.mappingEntry. This means empty SSM files caused the other branch to be selected. This is contrary to what the standard requires.Approach
Using
ssm is not Noneinstead ensures compliance to the SSP standard, by using the SSM branch even if there are no mappings. The effect is that no values are applied if an SSV is referenced through an "empty" SSM, which is what the standard implies.