fix: extensionless imports so Turbopack builds the i18n strings subpath#33
Merged
Merged
Conversation
…ngs subpath The strings subpath (packages/integration-framework/strings) and the DataSourceSections hook import used .js extensions on .ts sources. tsc and vitest rewrite .js->.ts, but the Next/Turbopack production build (only run in the web Docker image, not in check-types/vitest) cannot resolve them, breaking `pnpm build`. Match the rest of the workspace (e.g. the parent package and the prior poi-source-registry fix) by dropping the .js extensions.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Build webDocker job onmainbroke after #32: the Next/Turbopack production build couldn't resolve./src/resolver.jsfrom the@openmapx/integration-framework/stringssubpath (and./useDataSourceI18nResolver.jsin the place panel).tscand vitest rewrite.js→.ts, socheck-types/vitestpassed and the issue only surfaced in the web image build (pnpm build), which isn't run by those gates.Fix: drop the
.jsextensions on.ts-source relative imports, matching the rest of the workspace (the parent package is extensionless, same as the earlierpoi-source-registryTurbopack fix). Verified with a full localpnpm --filter web build(exit 0, 28 static pages generated).