feat: add Gateway API and storage options#4
Open
bowling233 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the openlist Helm chart to support additional deployment/exposure and customization options (Gateway API HTTPRoute, optional admin password provisioning, and an optional separate PVC for Local driver file storage), while also bumping defaults to OpenList v4.2.2.
Changes:
- Add Gateway API
HTTPRoutetemplate with configurable parentRefs/hostnames/labels/annotations/rules. - Add optional admin password provisioning via
admin.passwordoradmin.existingSecret(wired toOPENLIST_ADMIN_PASSWORD). - Add optional separate storage PVC (
storage.*) mounted independently from/opt/openlist/data, plus broader chart customization knobs (labels/annotations/resources/probes/scheduling, optional HTTPS service port).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Documents new values (HTTPRoute, admin password options, separate storage PVC) and updates defaults to v4.2.2. |
charts/openlist/values.yaml |
Adds new configuration values (namespace override, admin, storage, HTTPRoute, service labels/annotations, probes/resources/scheduling). |
charts/openlist/templates/openlist-storage-persistentvolumeclaim.yaml |
Adds optional PVC for separate file storage. |
charts/openlist/templates/openlist-service.yaml |
Adds namespace/labels/annotations support and optional HTTPS service port. |
charts/openlist/templates/openlist-persistentvolumeclaim.yaml |
Applies common labels and namespace helper. |
charts/openlist/templates/openlist-httproute.yaml |
Adds Gateway API HTTPRoute resource rendering. |
charts/openlist/templates/openlist-deployment.yaml |
Adds admin password env wiring, optional storage mount, probes/resources/scheduling knobs, and optional HTTPS container port. |
charts/openlist/templates/openlist-admin-secret.yaml |
Adds optional Secret creation for admin.password. |
charts/openlist/templates/_helpers.tpl |
Adds namespace helper, common labels, selector labels, and helper names for admin Secret / storage PVC. |
charts/openlist/Chart.yaml |
Bumps chart version and appVersion to v4.2.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+66
to
+68
| {{- define "openlist.adminSecretName" -}} | ||
| {{- default (printf "%s-admin" (include "openlist.fullname" .)) .Values.admin.existingSecret | trunc 63 | trimSuffix "-" -}} | ||
| {{- end -}} |
Comment on lines
+73
to
+75
| {{- define "openlist.storageClaimName" -}} | ||
| {{- default (printf "%s-storage" (include "openlist.fullname" .)) .Values.storage.existingClaim | trunc 63 | trimSuffix "-" -}} | ||
| {{- end -}} |
Add optional Gateway API HTTPRoute rendering with configurable parentRefs, hostnames, annotations, labels, and custom rules. Add admin password provisioning through admin.password and admin.existingSecret, exposing it to OpenList as OPENLIST_ADMIN_PASSWORD. Add a separate optional storage PVC for Local driver file storage so user files do not share /opt/openlist/data with application state. Add configurable Deployment updateStrategy support, defaulting to Recreate for ReadWriteOnce PVC compatibility. Add common deployment customization knobs for pod labels, pod annotations, extra env, probes, resources, scheduling, service labels, service annotations, and optional HTTPS service port. Update chart defaults and documentation for OpenList v4.2.2. Co-authored-by: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin.passwordoradmin.existingSecretusingOPENLIST_ADMIN_PASSWORD./opt/openlist/data.v4.2.2.AI Disclosure
This PR includes substantial AI-assisted content.