Repository navigation
Fix the Travis JS related tests - #300
Merged
Merged
Conversation
…refox via apt instead
daveol
approved these changes
Aug 2, 2022
daveol
left a comment
daveol
left a comment
Contributor
There was a problem hiding this comment.
Overall seems fine, some minor nitpicks
FloEdelmann
approved these changes
Aug 15, 2022
kripton
approved these changes
Oct 1, 2026
Commented out the installation of grunt-cli for certain tasks.
Add MOZ_HEADLESS environment variable for headless testing.
Run Karma JS tests via GitHub Actions
Add lint and closure-compiler tasks to CI workflow
Removed implemented tasks from the commented list
Update task matrix in test workflow
Member
Author
|
I'm going to merge as-is, because basically everyone had approved this and the delta of changes was just the minor bits to get our new CI of GitHub Actions to run it: This PR had been around so long it was still targeting Travis! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.