Preserve reg_info_*.bin during make clobber/distclean - #11
Merged
Conversation
The clobber target's recursive find matched every *.bin under OBJTREE, including the committed reg_info_hi3516av200.bin and reg_info_hi3519v101.bin source blobs at the repo root, forcing a git checkout to recover before each rebuild. Exclude them from the find so distclean still cleans mini-boot.bin, u-boot.bin and friends but leaves source data alone. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make clobber(and thereforemake distclean/make mrproper) was deleting the committedreg_info_hi3516av200.bin/reg_info_hi3519v101.binsource blobs at the repo root, because itsfind $(OBJTREE) ... -name '*.bin'swept them up alongside build artifacts.! -name 'reg_info_*.bin'filter to the find so the register-init source files survive a deep clean while everything else (mini-boot.bin,u-boot.bin, etc.) is still removed.make cleanwas never the culprit — its find pattern doesn't include*.bin. Onlyclobber/distclean/mrpropertriggered the deletion.Test plan
ls reg_info_*.binshows both files present.mini-boot.binandu-boot.binexist at root):make distcleanleaves bothreg_info_*.binin place and removesmini-boot.bin/u-boot.bin../build.shbuilds both SoCs end-to-end andreg_info_*.binare still present afterwards.