ci: use unified -M $machine,flash-file=$f syntax (qemu-hisilicon#80) - #4
Merged
Conversation
OpenIPC/qemu-hisilicon#80 / #81 added a machine-level flash-file property that forwards to whichever flash controller the SoC config wires up (hisi-fmc on V3+/Goke, hisi-sfc350 on V1/V2A). Drops the abstraction leak that required the consumer workflow to know which controller each machine uses. Replaces the two-line `-M $machine \\ -global hisi-*.flash-file=...` incantation with a single uniform `-M $machine,flash-file=...` that works for every SoC. Identical line across all 8 OpenIPC HiSi u-boot workflows now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenIPC/qemu-hisilicon#80 / #81 added a machine-level
flash-fileproperty that forwards to whichever flash controller the SoC config
wires up. The CI workflow no longer needs to know controller names.
Replaces:
(or the
hisi-sfc350variant) with the uniform:Identical smoke step across all 8 OpenIPC HiSi u-boot workflows now.
Test plan
qemu_smokejob passes on every matrix entry — samePASS: u-boot booted past System startupoutput as before.🤖 Generated with Claude Code