Fix dev container CI by returning server_protocol to upstream value - #443
Open
Rub21 wants to merge 3 commits into
Open
Fix dev container CI by returning server_protocol to upstream value#443Rub21 wants to merge 3 commits into
Rub21 wants to merge 3 commits into
Conversation
Coverage Report for CI Build 29773436014Warning No base build found for commit Coverage: 96.455%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
1ec5
approved these changes
Jul 21, 2026
Comment on lines
+2
to
+3
| server_protocol: "http" | ||
| server_url: "openstreetmap.example.com" |
Member
There was a problem hiding this comment.
Make sure that OpenHistoricalMap/issues#1091 hasn’t regressed per #301 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OpenHistoricalMap/issues#1407
Fixes OpenHistoricalMap/issues#1180
The dev container CI was failing because
settings.ymlhad server_protocol=https (introduced in 234f272). With that value the app tries to work with Secure cookies, which does not work for tests.I have also fixed the teaspoon locationCookie tests by using the Mapnik layer. This is the same change as in #439, but I had to include it here too to make sure all tests pass.